Page MenuHomePhabricator

Allow passing gitconfig values at clone/fetch time
ClosedPublic

Authored by demon on Feb 27 2018, 9:41 PM.

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCAf1404f7f131a: Allow passing gitconfig values at clone/fetch time
Patch without arc
git checkout -b D989 && curl -L https://phabricator.wikimedia.org/D989?download=true | git apply

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Feb 27 2018, 9:41 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptFeb 27 2018, 9:41 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Feb 27 2018, 9:55 PM
thcipriani added inline comments.
scap/git.py
326

Since you're calling items should this be a dict?

demon updated this revision to Diff 2594.Feb 27 2018, 11:04 PM
  • swap list for dict
thcipriani accepted this revision.Feb 27 2018, 11:14 PM
This revision is now accepted and ready to land.Feb 27 2018, 11:14 PM
This revision was automatically updated to reflect the committed changes.