Page MenuHomePhabricator
Differential D991

Generalize instructions for entrypoint and working directory
ClosedPublic
Actions

Authored by dduvall on Feb 28 2018, 1:15 AM.
Tags
Referenced Files
Unknown Object (File)
Sun, Nov 12, 1:56 AM
Unknown Object (File)
Mon, Nov 6, 8:50 PM
Unknown Object (File)
Oct 26 2023, 7:03 PM
Unknown Object (File)
Oct 23 2023, 4:03 AM
Unknown Object (File)
Oct 11 2023, 9:14 AM
Unknown Object (File)
Sep 27 2023, 12:58 PM
Unknown Object (File)
Sep 22 2023, 3:51 AM
Unknown Object (File)
Sep 21 2023, 12:51 AM
View All 24 Files
Subscribers
None

Details

Reviewers
thcipriani
demon
hashar
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR0902d688e996: Generalize instructions for entrypoint and working directory
Patch without arc
git checkout -b D991 && curl -L https://phabricator.wikimedia.org/D991?download=true | git apply
Summary

Introduce new build.EntryPoint and build.WorkingDirectory
instructions to allow configuration to inject them instead of hard
coding their generation in the Docker compiler.

Simplified the Docker compiler to simply iterate over build phases as
returned by a new function build.Phases().

Depends on D990

Test Plan

Run go test ./....

Diff Detail

Repository
rGBLBR Blubber
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dduvall created this revision.Feb 28 2018, 1:15 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptFeb 28 2018, 1:15 AM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
dduvall requested review of this revision.Feb 28 2018, 1:15 AM
Harbormaster completed remote builds in Restricted Buildable.Feb 28 2018, 1:15 AM
thcipriani accepted this revision.Mar 6 2018, 12:02 AM

Makes sense, looks good, works well. Nice :)

This revision is now accepted and ready to land.Mar 6 2018, 12:02 AM
Closed by commit rGBLBR0902d688e996: Generalize instructions for entrypoint and working directory (authored by dduvall). · Explain WhyMar 6 2018, 12:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
build/
25 lines
12 lines
12 lines
config/
4 lines
7 lines
4 lines
15 lines
docker/
19 lines
7 lines
20 lines

Diff 2618

View Options

build/instructions.go

Loading...
View Options

build/instructions_test.go

Loading...
View Options

build/phases.go

Loading...
View Options

config/lives.go

Loading...
View Options

config/lives_test.go

Loading...
View Options

config/variant.go

Loading...
View Options

config/variant_test.go

Loading...
View Options

docker/compiler.go

Loading...
View Options

docker/instructions.go

Loading...
View Options

docker/instructions_test.go

Loading...
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL