Page MenuHomePhabricator

Generalize instructions for entrypoint and working directory
ClosedPublic

Authored by dduvall on Feb 28 2018, 1:15 AM.

Details

Reviewers
thcipriani
demon
hashar
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR0902d688e996: Generalize instructions for entrypoint and working directory
Patch without arc
git checkout -b D991 && curl -L https://phabricator.wikimedia.org/D991?download=true | git apply
Summary

Introduce new build.EntryPoint and build.WorkingDirectory
instructions to allow configuration to inject them instead of hard
coding their generation in the Docker compiler.

Simplified the Docker compiler to simply iterate over build phases as
returned by a new function build.Phases().

Depends on D990

Test Plan

Run go test ./....

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dduvall created this revision.Feb 28 2018, 1:15 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptFeb 28 2018, 1:15 AM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
dduvall requested review of this revision.Feb 28 2018, 1:15 AM
thcipriani accepted this revision.Mar 6 2018, 12:02 AM

Makes sense, looks good, works well. Nice :)

This revision is now accepted and ready to land.Mar 6 2018, 12:02 AM
This revision was automatically updated to reflect the committed changes.