Page MenuHomePhabricator
Differential D994

Run .mpg and .mpeg files through the video/ffmpeg processor
Needs RevisionPublic
Actions

Authored by brion on Feb 28 2018, 9:26 PM.

Details

Reviewers
Gilles
Patch without arc
git checkout -b D994 && curl -L https://phabricator.wikimedia.org/D994?download=true | git apply
Summary

Once MPEG-1 and MPEG-2 files are allowed for uploads (T166024)
we'll want to thumbnail them too. Existing infrastructure for
video thumbnailing via ffmpeg should require no additional
changes.

It should also be safe to merge/deploy this change before the
actual enabling of uploads, since there will simply be no matching
files.

Bug: T166024

Diff Detail

Event Timeline

brion created this revision.Feb 28 2018, 9:26 PM
Restricted Application added a reviewer: Gilles. · View Herald TranscriptFeb 28 2018, 9:26 PM
brion requested review of this revision.Feb 28 2018, 9:27 PM
brion updated this revision to Diff 2605.Feb 28 2018, 9:28 PM

Fixed stray 'endswidth' typo

Gilles requested changes to this revision.Mar 1 2018, 8:55 AM

Please add test files for both types. This will ensure when the Debian package is built that ffmpeg has the right codecs for those formats.

See test_video.py, it should be straightforward to add a new test in there, using a reference thumbnail you'd generate manually with ffmpeg.

The smaller the test videos, the better ;)

This revision now requires changes to proceed.Mar 1 2018, 8:55 AM
brion added a comment.Mar 1 2018, 8:39 PM

Will do. :)

Revision Contents
Changeset List

Diff 2605

View Options

wikimedia_thumbor/loader/video/__init__.py

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL