Page MenuHomePhabricator

Makefile: install to global GOPATH with correct -ldflags
ClosedPublic

Authored by thcipriani on Mar 6 2018, 12:19 AM.

Details

Reviewers
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rGBLBRb790283b431a: Makefile: install to global GOPATH with correct -ldflags
Patch without arc
git checkout -b D998 && curl -L https://phabricator.wikimedia.org/D998?download=true | git apply
Summary

Since we now use ldflags to set global variables it's helpful to
automate via Make. Using a single global GOPATH seems to jive more with
the best-practice established in the go community[0] and make
testing/code review easier.

[0]. https://github.com/golang/go/wiki/GOPATH#use-a-single-gopath

Test Plan

run make

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Mar 6 2018, 12:19 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMar 6 2018, 12:19 AM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Mar 6 2018, 12:19 AM
thcipriani updated this revision to Diff 2616.Mar 6 2018, 12:32 AM

Remove -i flag

dduvall accepted this revision.Mar 6 2018, 12:34 AM
This revision is now accepted and ready to land.Mar 6 2018, 12:34 AM
This revision was automatically updated to reflect the committed changes.