HomePhabricator

Code Review Office Hours
ActivePublic

Hosted by mmodell on Jun 2 2016, 8:00 PM - 9:00 PM.

Description

What's this all about

This is an initiative of Wikimedia Developer-Advocacy and Release-Engineering-Team-TODO (201907) intended to promote quality and timely code reviews on Wikimedia projects. See T128371: Set up Code Review office hours for related discussion.

How does it work

If you have a patch that needs attention, please subscribe to this event and post a link to your patch in the comments, then show up on freenode IRC in the #wikimedia-codereview channel during the scheduled office hours. Developers with +2 should be on hand to review patches, provide feedback and merge any acceptable/deployable patches.

Nominated Patches

@nameTnnn...

Other Patches "for-review"

Recurring Event

Event Series
This event is an instance of E181: Code Review Office Hours, and repeats every week.

Event Timeline

TTO added a comment.Jun 1 2016, 11:43 AM

It looks like Chughakshay16 is long gone, so I'm happy to shepherd the first one through the office hour.

mmodell updated the event description. (Show Details)Jun 2 2016, 7:55 PM
mmodell updated the event description. (Show Details)
Danny_B invited: ; uninvited: .Jun 2 2016, 8:13 PM
Bawolff added a subscriber: Bawolff.Jun 2 2016, 8:43 PM

I'd like to propose a new rule. Any suggested patches must:

  • have been rebased in the last month (Or at least, still cleanly apply to master. If they need minor rebasing I don't think it matters, but if they've been bit rotting for 2 years, I don't think they should be listed here)
  • Not be gigantic. I don't think these types of office hours are the place for big sweeping complicated changes. e.g. If the patch touches more then 500 lines, it should be excluded. (Maybe line count isn't the best thing to judge something by)

@Bawolff: agreed, I think you're right on both points.

Mholloway invited: ; uninvited: .Jun 3 2016, 1:23 AM
Paladox added a subscriber: Paladox.Jun 3 2016, 1:35 AM