HomePhabricator

Code Review Office Hours
ActivePublic

Hosted by mmodell on Dec 15 2016, 8:00 PM - 9:00 PM.

Description

What's this all about

This is an initiative of Wikimedia Developer-Advocacy and Release-Engineering-Team-TODO (201907) intended to promote quality and timely code reviews on Wikimedia projects. See T128371: Set up Code Review office hours for related discussion and the overview on mediawiki.org Code_Review/Office_Hours

How does it work

If you have a patch that needs attention, please subscribe to this event and post a link to your patch in the comments, then show up on freenode IRC in the #wikimedia-codereview channel during the scheduled office hours. Developers with +2 should be on hand to review patches, provide feedback and merge any acceptable/deployable patches.

Nominated Patches

Suggested byTask and/or Description of patchLink to patch
@nameTnnn...

Other Patches "for-review"

Recurring Event

Event Series
This event repeats every week.

Event Timeline

Suggested byTask and/or Description of patchLink to patch
@FreedomFighterSparrowT106075https://gerrit.wikimedia.org/r/#/c/324722/
@FreedomFighterSparrowConvert extension:Lockdown to extension registrationhttps://gerrit.wikimedia.org/r/#/c/325281/

I don't care about the 2nd one as much.

Mholloway changed the start date for this event from Dec 15 2016, 8:00 PM to Dec 15 2016, 8:00 PM.Dec 14 2016, 12:52 PM
Mholloway changed the end date for this event from Dec 15 2016, 9:00 PM to Dec 15 2016, 9:00 PM.
Mholloway uninvited: Mholloway.
Mholloway added a subscriber: Mholloway.

Er, sorry if I've accidentally changed the time, only meant to un-invite myself.

EddieGP added a subscriber: EddieGP.

Adding the same tags as in E206 as this is obviously the same here.

EddieGP changed this event to repeat until Mar 23 2018, 12:00 AM.Apr 4 2018, 10:56 AM
Jayprakash12345 added a comment.EditedApr 5 2018, 3:47 AM
Suggested byTask and/or Description of patchLink to patch
@Jayprakash12345Fix isLoggedIn function callhttps://gerrit.wikimedia.org/r/#/c/422202/
@Jayprakash12345Remove deprecated global function wfRunHookshttps://gerrit.wikimedia.org/r/#/c/417984/
@Jayprakash12345Convert Arrays to use extension registrationhttps://gerrit.wikimedia.org/r/#/c/405057/
Jayprakash12345 is attending this event.Apr 5 2018, 3:50 AM
Suggested byTask and/or Description of patchLink to patch
@JHunterHChange <a> and <div> tags to <button>shttps://gerrit.wikimedia.org/r/#/c/408577/
Suggest byTask and/or Description of patchLink to patch
@JazielPaudaFix HTML headings structure in SpecialQuizGameHomehttps://gerrit.wikimedia.org/r/#/c/416887/