HomePhabricator

Code Review Office Hours
ActivePublic

Hosted by mmodell on Feb 23 2017, 8:00 PM - 9:00 PM.

Description

What's this all about

This is an initiative of Wikimedia Developer-Advocacy and Release-Engineering-Team intended to promote quality and timely code reviews on Wikimedia projects. See T128371: Set up Code Review office hours for related discussion and the overview on mediawiki.org Code_Review/Office_Hours

How does it work

If you have a patch that needs attention, please subscribe to this event and post a link to your patch in the comments, then show up on freenode IRC in the #wikimedia-codereview channel during the scheduled office hours. Developers with +2 should be on hand to review patches, provide feedback and merge any acceptable/deployable patches.

Nominated Patches

Suggested byTask and/or Description of patchLink to patch
@nameTnnn...

Other Patches "for-review"

Recurring Event

Event Series
This event is an instance of E415: Code Review Office Hours, and repeats every week.

Event Timeline

Would like feedback on the following (some of which I'm not the author but did a rebase or a follow-up, I hope that's okay):

taskgerritshort description
T157178https://gerrit.wikimedia.org/r/#/c/335958/Add CSS classes for diff and history links at OldRecentChanges
T157178https://gerrit.wikimedia.org/r/#/c/338921/Add CSS classes for diff and history links at EnhancedRecentChanges
T156879https://gerrit.wikimedia.org/r/#/c/338350/Add CSS classes for user links
T109979https://gerrit.wikimedia.org/r/#/c/243484/Modify footer icons to use $wgExternalLinkTarget
T4335https://gerrit.wikimedia.org/r/#/c/338965/Make Special:WantedPages, WantedImages etc. sort alphabetically for page names that have the same count (really ugly code IMHO, but comments would help to find a better solution)