Page MenuHomePhabricator

2018-06-30 01-48-36.mkv

File Metadata

Author
matmarex
Created
Jun 29 2018, 11:49 PM

2018-06-30 01-48-36.mkv

No document engine can render the contents of this file.

Event Timeline

I wasn't able to view the file properly.

@Hagarshilo I can view it with a program called VLC

@Hagarshilo I can view it with a program called VLC

Thank you. I didn't see the Download button, only the option to view in Phabricator as a hexdump, which seemed very very useless. Now I see. Such a fun bug!

@Hagarshilo this is pretty interesting... one idea that you could explore is to have your fix only work for diff pages. Look for a class (probably on <body>) that is on diff pages specifically, and add that class as a super selector to your rule.
IT's not a perfect solution, since the original bug may happen in history pages too, but it seems to have less chances of existing there anyways (?)

(For context, this file describes an issue I saw with change https://gerrit.wikimedia.org/r/441078.)

Hagarshilo added a comment.EditedJul 4 2018, 2:46 PM

@Hagarshilo this is pretty interesting... one idea that you could explore is to have your fix only work for diff pages. Look for a class (probably on <body>) that is on diff pages specifically, and add that class as a super selector to your rule.
IT's not a perfect solution, since the original bug may happen in history pages too, but it seems to have less chances of existing there anyways (?)

So I've explored a bit and here's what I've found.

  1. Adding '.action-view' as the first selector in 'ext.thanks.less' prevents this bug from happening on No/Cancel in History, but it still occurs upon Cancel in Diff. So it still needs fixing.
  2. Using '.action-view .jquery-confirmable-text' instead of '.action-view .jquery-confirmable-wrapper .jquery-confirmable-interface .jquery-confirmable-text' seems to be enough, things behave the same. That's nice, but I don't think I should make an additional change right now, in case this breaks something else.

I have a new bad solution: remove the span element that contains the "All thanks are public..." text when pressing Cancel. What I would rather do, though, is find out what clashes with applying 'white-space: normal'. This is what I'm trying to do now.