Page MenuHomePhabricator
Files F2535324

T111029-2.patch
Grunny (Grunny)
Actions

Authored By
Grunny
Sep 3 2015, 5:27 AM
Size
1 KB
Referenced Files
None
Subscribers
None

T111029-2.patch
View Options

From 3ab96bfcba9f3f4db75bdc1063d9d95b9c3ac232 Mon Sep 17 00:00:00 2001
From: grunny <mwgrunny@gmail.com>
Date: Tue, 1 Sep 2015 20:26:50 +1000
Subject: [PATCH] SECURITY: Encode history URL in review toolbar
Encode history URL in review toolbar and HTML escape for good measure.
Bug: T111029
---
modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.html | 2 +-
modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.html b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.html
index 9a57fd4..091cecb 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.html
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.html
@@ -52,7 +52,7 @@
<%= mw.msg( 'pagetriage-info-history-header' ) %>
<span class="mwe-pt-info-header-details">
<%= mw.msg( 'pagetriage-edits', rev_count ) %> &#xb7;
- <a href="<%= history_link %>"><%= mw.msg( 'pagetriage-info-history-show-full' ) %></a>
+ <a href="<%= mw.html.escape( history_link ) %>"><%= mw.message( 'pagetriage-info-history-show-full' ).escaped() %></a>
</span>
</div>
<div class="mwe-pt-info-content" id="mwe-pt-info-history-container"></div>
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.js b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.js
index 03e8b23..fc62d17 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.js
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.articleInfo.js
@@ -20,7 +20,7 @@ $( function() {
this.model.set(
'history_link',
this.model.buildLink(
- mw.config.get( 'wgArticlePath' ).replace( '$1', mw.config.get( 'wgPageName' ) ),
+ mw.util.getUrl( mw.config.get( 'wgPageName' ) ),
'action=history'
)
);
--
1.9.1

File Metadata

Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2549226
Default Alt Text
T111029-2.patch (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL