Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F26647808
0001-SECURITY-Include-IP-address-in-Login-for-1-succeeded.patch
Legoktm (Legoktm)
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Authored By
Legoktm
Oct 20 2018, 12:35 PM
2018-10-20 12:35:56 (UTC+0)
Size
1 KB
Referenced Files
None
Subscribers
None
0001-SECURITY-Include-IP-address-in-Login-for-1-succeeded.patch
View Options
From 6b137720ec83ab6b092d0f3f9e67ad4db78dc103 Mon Sep 17 00:00:00 2001
From: Kunal Mehta <legoktm@member.fsf.org>
Date: Sat, 20 Oct 2018 05:35:22 -0700
Subject: [PATCH] [SECURITY] Include IP address in "Login for $1 succeeded" log
entry
Bug: T207540
Change-Id: Iab4f2f2ddc8e64ead2f33356d03fa7beed399415
---
includes/auth/AuthManager.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/includes/auth/AuthManager.php b/includes/auth/AuthManager.php
index ab7ba0fb8c..f53e0c6fca 100644
--- a/includes/auth/AuthManager.php
+++ b/includes/auth/AuthManager.php
@@ -681,8 +681,9 @@ class AuthManager implements LoggerAwareInterface {
// Step 4: Authentication complete! Set the user in the session and
// clean up.
- $this->logger->info( 'Login for {user} succeeded', [
+ $this->logger->info( 'Login for {user} succeeded from {ipaddr}', [
'user' => $user->getName(),
+ 'ipaddr' => $this->request->getIP(),
] );
/** @var RememberMeAuthenticationRequest $req */
$req = AuthenticationRequest::getRequestByClass(
--
2.17.2
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
6563486
Default Alt Text
0001-SECURITY-Include-IP-address-in-Login-for-1-succeeded.patch (1 KB)
Attached To
Mode
T207540: "Login for $1 succeeded" should include IP information
Attached
Detach File
Event Timeline
Log In to Comment