Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F2880385
patrol.patch
Bawolff (Brian Wolff)
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
Bawolff
Oct 27 2015, 9:28 AM
2015-10-27 09:28:01 (UTC+0)
Size
2 KB
Referenced Files
None
Subscribers
None
patrol.patch
View Options
From 195a3cefc6ba5cd1289829068d34c0727a6075d3 Mon Sep 17 00:00:00 2001
From: Brian Wolff <bawolff+wn@gmail.com>
Date: Tue, 27 Oct 2015 02:31:00 -0600
Subject: [PATCH] Add class to <a> for patrol links so it can't be spoofed by
user
Javascript used to look just for the patrollinks class, which
could be set by the user in order to patrol an arbitrary page.
Requiring the class on the <a> tag prevents the user from setting
it.
Change-Id: I13fcc3ce479c0a4a90a6217c2e5244f051eaf862
---
includes/diff/DifferenceEngine.php | 2 +-
includes/page/Article.php | 2 +-
resources/src/mediawiki/page/patrol.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index ae610fa..f5ff44f 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -510,7 +510,7 @@ class DifferenceEngine extends ContextSource {
$this->mMarkPatrolledLink = ' <span class="patrollink">[' . Linker::linkKnown(
$this->mNewPage,
$this->msg( 'markaspatrolleddiff' )->escaped(),
- array(),
+ array( 'class' => 'mw-patrollink' ),
array(
'action' => 'markpatrolled',
'rcid' => $rcid,
diff --git a/includes/page/Article.php b/includes/page/Article.php
index 5d6435e..408b532 100644
--- a/includes/page/Article.php
+++ b/includes/page/Article.php
@@ -1167,7 +1167,7 @@ class Article implements Page {
$link = Linker::linkKnown(
$this->getTitle(),
wfMessage( 'markaspatrolledtext' )->escaped(),
- array(),
+ array( 'class' => 'mw-patrollink' ),
array(
'action' => 'markpatrolled',
'rcid' => $rcid,
diff --git a/resources/src/mediawiki/page/patrol.js b/resources/src/mediawiki/page/patrol.js
index f9b0d35..e0307b7 100644
--- a/resources/src/mediawiki/page/patrol.js
+++ b/resources/src/mediawiki/page/patrol.js
@@ -12,7 +12,7 @@
return;
}
$( function () {
- var $patrolLinks = $( '.patrollink a' );
+ var $patrolLinks = $( '.patrollink a.mw-patrollink' );
$patrolLinks.on( 'click', function ( e ) {
var $spinner, href, rcid, apiRequest;
--
2.0.1
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2892012
Default Alt Text
patrol.patch (2 KB)
Attached To
Mode
T103239: Patrol allows click catching and patrolling of any page
Attached
Detach File
Event Timeline
Log In to Comment