T241503.patch
MarcoAurelio
Actions

Authored By

	MarcoAurelio
	Jan 2 2020, 5:30 PM

Size

1 KB

Referenced Files

None

Subscribers

None

T241503.patch
View Options

	commit 5c2b9ecaaee8909158500708800d064fd3756698
	Author: MarcoAurelio <maurelio@tools.wmflabs.org>
	Date: Thu Jan 2 18:23:53 2020 +0100

	SECURITY: Temporary add old abusefilter permissions

	AbuseFilter permissions controling access to private information were
	renamed in c7ccb6805. While local permissions were renamed in the
	configuration accordingly, global groups are managed on-wiki and we need
	to add them back so stewards can swap them accordingly on meta.wikimedia

	This patch does not really need to be deployed and can be reverted as soon as
	the swap has been done, for which I will attempt to coordinate with a deployer.

	Bug: T241503
	Change-Id: Ic11bc019a2c29b083512799181e192269f411db0

	diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
	index 32e95159b..0ee48d0d5 100644
	--- a/wmf-config/CommonSettings.php
	+++ b/wmf-config/CommonSettings.php
	@@ -881,6 +881,12 @@ if (
	// Note these have to be visible on all wikis, not just the ones the
	// extension is enabled on, for proper display in OAuth pages and such.

	+// Temporary adding AbuseFilter "old" rights renamed in [[gerrit:482650]] so we can remove them
	+// from global groups while also switching to the new ones.
	+// MarcoAurelio, 2020-01-02; cfr. T241503
	+$wgAvailableRights[] = 'abusefilter-private';
	+$wgAvailableRights[] = 'abusefilter-private-log';
	+
	// Adding Flaggedrevs rights so that they are available for globalgroups/staff rights - JRA 2013-07-22
	$wgAvailableRights[] = 'autoreview';
	$wgAvailableRights[] = 'autoreviewrestore';