T294686.patch
Urbanecm (Martin Urbanec)
Actions

Authored By

	Urbanecm
	Oct 30 2021, 1:09 PM

Size

1 KB

Referenced Files

None

Subscribers

None

T294686.patch
View Options

	From 3c2bcb4cb93cd9cf6a1c7174c067ed03b0144c08 Mon Sep 17 00:00:00 2001
	From: Martin Urbanec <martin.urbanec@wikimedia.cz>
	Date: Sat, 30 Oct 2021 15:08:06 +0200
	Subject: [PATCH] SECURITY: Pass required parameters to DeletePageJob

	Without the params, the job does not actually delete the page,
	rendering Nuke useless.

	Bug: T294686
	Change-Id: I61f47961e1d4739a290ed53704e87887e3f59f23
	---
	includes/SpecialNuke.php \| 8 ++++++--
	1 file changed, 6 insertions(+), 2 deletions(-)

	diff --git a/includes/SpecialNuke.php b/includes/SpecialNuke.php
	index 50f98db..150e0f3 100644
	--- a/includes/SpecialNuke.php
	+++ b/includes/SpecialNuke.php
	@@ -382,9 +382,13 @@ class SpecialNuke extends SpecialPage {
	} else {
	$job = new DeletePageJob( [
	'namespace' => $title->getNamespace(),
	- 'title' => $title->getId(),
	+ 'title' => $title->getDBKey(),
	'reason' => $reason,
	- 'userId' => $user->getId()
	+ 'userId' => $user->getId(),
	+ 'wikiPageId' => $title->getId(),
	+ 'suppress' => false,
	+ 'tags' => '[]',
	+ 'logsubtype' => 'delete',
	] );
	$jobs[] = $job;
	$status = 'job';
	--
	2.20.1