Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F35213103
01-T308473.patch
sbassett (Scott Bassett)
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Authored By
sbassett
Jun 6 2022, 9:20 PM
2022-06-06 21:20:25 (UTC+0)
Size
1 KB
Referenced Files
None
Subscribers
None
01-T308473.patch
View Options
From 89d22c4920782b245908f0a1307606be175415cf Mon Sep 17 00:00:00 2001
From: sbassett <sbassett@wikimedia.org>
Date: Mon, 6 Jun 2022 16:17:16 -0500
Subject: [PATCH] SECURITY: Escape contributions-title msg for use within page
title
Bug: T308473
---
includes/specials/SpecialContributions.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php
index 407e9c110e..d8f822974c 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -214,7 +214,7 @@ class SpecialContributions extends IncludableSpecialPage {
}
$out->addSubtitle( $this->contributionsSub( $userObj, $target ) );
- $out->setPageTitle( $this->msg( 'contributions-title', $target ) );
+ $out->setPageTitle( $this->msg( 'contributions-title', $target )->escaped() );
} else {
$nt = Title::makeTitleSafe( NS_USER, $target );
if ( !$nt ) {
@@ -233,7 +233,7 @@ class SpecialContributions extends IncludableSpecialPage {
$id = $userObj->getId();
$out->addSubtitle( $this->contributionsSub( $userObj, $target ) );
- $out->setPageTitle( $this->msg( 'contributions-title', $target ) );
+ $out->setPageTitle( $this->msg( 'contributions-title', $target )->escaped() );
# For IP ranges, we want the contributionsSub, but not the skin-dependent
# links under 'Tools', which may include irrelevant links like 'Logs'.
--
2.30.2
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
9499965
Default Alt Text
01-T308473.patch (1 KB)
Attached To
Mode
T308473: CVE-2022-34912: Username not escaped in the contributions-title message
Attached
Detach File
Event Timeline
Log In to Comment