Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F4828046
Remove timecorrection, skin, language, variant from labsdb views
No One
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Authored By
Bawolff
Nov 23 2016, 5:29 PM
2016-11-23 17:29:55 (UTC+0)
Size
1 KB
Referenced Files
None
Subscribers
None
Remove timecorrection, skin, language, variant from labsdb views
View Options
From 6d04740a6482b1bdb750efc99cd603cdd33c065a Mon Sep 17 00:00:00 2001
From: Brian Wolff <bawolff+wn@gmail.com>
Date: Wed, 23 Nov 2016 17:26:22 +0000
Subject: [PATCH] Remove language, variant, skin and timecorrection prefs from
labsdb
These preferences are kept secret by MediaWiki, and thus should not
be exposed by the labsdb public databases. In particular,
timecorrection is strongly correlated to user location, and thus
it is important that we keep it private.
Bug: T150679
---
modules/role/templates/labsdb/maintain-views.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/modules/role/templates/labsdb/maintain-views.yaml b/modules/role/templates/labsdb/maintain-views.yaml
index 303c780..1434b37 100644
--- a/modules/role/templates/labsdb/maintain-views.yaml
+++ b/modules/role/templates/labsdb/maintain-views.yaml
@@ -346,8 +346,7 @@ customviews:
source: user_properties
view: select up_user, up_property, up_value
where: >
- up_property in ( 'disablemail', 'fancysig', 'gender', 'language',
- 'nickname', 'skin', 'timecorrection', 'variant' )
+ up_property in ( 'disablemail', 'fancysig', 'gender', 'nickname' )
user_properties_anon:
limit: 2
source: ["user_properties", "user", "meta_p.properties_anon_whitelist" ]
--
1.9.5 (Apple Git-50.3)
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
4158424
Default Alt Text
Remove timecorrection, skin, language, variant from labsdb views (1 KB)
Attached To
Mode
T150679: Some Labs DB user_properties view fields are sensitive
Attached
Detach File
Event Timeline
Log In to Comment