Page MenuHomePhabricator
Files F58374394

lazyImageLoader.patch
LMora-WMF (LorenMora)
Actions

Authored By
LMora-WMF
Feb 7 2025, 9:59 PM
Size
1 KB
Referenced Files
None
Subscribers
None

lazyImageLoader.patch
View Options

diff --git a/includes/Transforms/LazyImageTransform.php b/includes/Transforms/LazyImageTransform.php
index fdf9f2db1..5a9342782 100644
--- a/includes/Transforms/LazyImageTransform.php
+++ b/includes/Transforms/LazyImageTransform.php
@@ -195,7 +195,8 @@ class LazyImageTransform implements IMobileTransform {
);
foreach ( [ 'src', 'alt', 'width', 'height', 'srcset', 'class', 'usemap' ] as $attr ) {
if ( $img->hasAttribute( $attr ) ) {
- $imgPlaceholder->setAttribute( "data-$attr", $img->getAttribute( $attr ) );
+ $prefix = $attr === 'src' ? 'data-mw-' : 'data-';
+ $imgPlaceholder->setAttribute( $prefix . $attr, $img->getAttribute( $attr ) );
}
}
// Assume data saving and remove srcset attribute from the non-js experience
diff --git a/resources/dist/mobile.common.js b/resources/dist/mobile.common.js
index d8c757666..4897aaf06 100644
Binary files a/resources/dist/mobile.common.js and b/resources/dist/mobile.common.js differ
diff --git a/resources/dist/mobile.common.js.map.json b/resources/dist/mobile.common.js.map.json
index 72ecc50ce..5a3ea399b 100644
Binary files a/resources/dist/mobile.common.js.map.json and b/resources/dist/mobile.common.js.map.json differ
diff --git a/src/mobile.startup/lazyImages/lazyImageLoader.js b/src/mobile.startup/lazyImages/lazyImageLoader.js
index 8cb6bb57c..3f21ee594 100644
--- a/src/mobile.startup/lazyImages/lazyImageLoader.js
+++ b/src/mobile.startup/lazyImages/lazyImageLoader.js
@@ -75,7 +75,8 @@ function loadImage( placeholder ) {
}, { once: true } );
// Trigger image download after binding the load handler
- image.src = placeholder.dataset.src || '';
+ // Todo: Remove placeholder.dataset.src once cache is reset
+ image.src = placeholder.dataset.mwSrc || placeholder.dataset.src || '';
image.srcset = placeholder.dataset.srcset || '';
return {

File Metadata

Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
19244010
Default Alt Text
lazyImageLoader.patch (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits