Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F8434
32792.patch
Public
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
•
bzimport
Nov 21 2014, 11:59 PM
2014-11-21 23:59:50 (UTC+0)
Size
4 KB
Referenced Files
None
Subscribers
None
32792.patch
View Options
Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
===================================================================
--- trunk/extensions/ProofreadPage/ProofreadPage_body.php (revision 105341)
+++ trunk/extensions/ProofreadPage/ProofreadPage_body.php (working copy)
@@ -35,7 +35,7 @@
if ( $namespace !== null ) {
return $namespace;
}
- $namespaceText = strtolower( wfMsgForContent( 'proofreadpage_namespace' ) );
+ $namespaceText = strtolower( str_replace( ' ', '_', wfMsgForContent( 'proofreadpage_namespace' ) ) );
$namespace = MWNamespace::getCanonicalIndex( $namespaceText );
return $namespace;
}
@@ -50,7 +50,7 @@
if ( $namespace !== null ) {
return $namespace;
}
- $namespaceText = strtolower( wfMsgForContent( 'proofreadpage_index_namespace' ) );
+ $namespaceText = strtolower( str_replace( ' ', '_', wfMsgForContent( 'proofreadpage_index_namespace' ) ) );
$namespace = MWNamespace::getCanonicalIndex( $namespaceText );
return $namespace;
}
@@ -841,7 +841,7 @@
list( $page, $pagenum ) = $item;
$pp[] = $page;
}
- $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( $page_namespace ) );
+ $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $page_namespace ) ) );
$dbr = wfGetDB( DB_SLAVE );
$cat = str_replace( ' ' , '_' , wfMsgForContent( 'proofreadpage_quality0_category' ) );
$res = $dbr->select(
@@ -1352,7 +1352,7 @@
*/
private static function update_pr_index( $index, $deletedpage = null ) {
list( $page_namespace, $index_namespace ) = self::getPageAndIndexNamespace();
- $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( $page_namespace ) );
+ $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $page_namespace ) ) );
if ( $page_ns_index == null ) {
return;
}
@@ -1442,8 +1442,8 @@
return true;
}
list( $page_namespace, $index_namespace ) = self::getPageAndIndexNamespace();
- $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( $page_namespace ) );
- $index_ns_index = MWNamespace::getCanonicalIndex( strtolower( $index_namespace ) );
+ $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $page_namespace ) ) );
+ $index_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $index_namespace ) ) );
if( $page_ns_index == null || $index_ns_index == null ) {
return true;
}
Index: trunk/extensions/ProofreadPage/SpecialProofreadPages.php
===================================================================
--- trunk/extensions/ProofreadPage/SpecialProofreadPages.php (revision 105341)
+++ trunk/extensions/ProofreadPage/SpecialProofreadPages.php (working copy)
@@ -35,7 +35,7 @@
);
if( $this->searchTerm ) {
$index_namespace = $this->index_namespace;
- $index_ns_index = MWNamespace::getCanonicalIndex( strtolower( $index_namespace ) );
+ $index_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $index_namespace ) ) );
$searchEngine = SearchEngine::create();
$searchEngine->setLimitOffset( $limit, $offset );
$searchEngine->setNamespaces( array( $index_ns_index ) );
@@ -89,7 +89,7 @@
if ( $this->searchTerm ) {
if ( $this->searchList !== null ) {
$index_namespace = $this->index_namespace;
- $index_ns_index = MWNamespace::getCanonicalIndex( strtolower( $index_namespace ) );
+ $index_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $index_namespace ) ) );
$conds = array( 'page_namespace' => $index_ns_index );
if ( $this->searchList ) {
$conds['page_title'] = $this->searchList;
Index: trunk/extensions/ProofreadPage/SpecialPagesWithoutScans.php
===================================================================
--- trunk/extensions/ProofreadPage/SpecialPagesWithoutScans.php (revision 105341)
+++ trunk/extensions/ProofreadPage/SpecialPagesWithoutScans.php (working copy)
@@ -76,7 +76,7 @@
function getQueryInfo() {
$dbr = wfGetDB( DB_SLAVE );
- $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( $this->page_namespace ) );
+ $page_ns_index = MWNamespace::getCanonicalIndex( strtolower( str_replace( ' ', '_', $this->page_namespace ) ) );
// Construct subqueries
$pagesWithScansSubquery = $dbr->selectSQLText(
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
7955
Default Alt Text
32792.patch (4 KB)
Attached To
Mode
T34792: Proofread Page extension inconsistently expects escaped spaces in namespaces
Attached
Detach File
Event Timeline
Log In to Comment