Page MenuHomePhabricator

Android bottom sheets
OpenPublic

Authored By
KHammerstein, Nov 23 2015
Tags
None
Referenced Files
F3009090: ANDROID-06-06.png
Nov 24 2015, 12:43 AM
F3009084: ANDROID-06.png
Nov 24 2015, 12:41 AM
F3008952: ANDROID-07.png
Nov 23 2015, 11:33 PM
F3008953: ANDROID-06.png
Nov 23 2015, 11:33 PM
Subscribers

Mock History

Current Revision

Event Timeline

@KHammerstein, these are great! I have a few questions on this, some of which will probably be answered by iterative development and design, but I thought they were worth wondering about now. Most of the questions are open ended so don't feel obligated to respond to them.

  1. What do these look like in landscape? Do they stretch? Are they more narrow? Do they have a target percentage width and height and max pixel width and height?
  2. I love that you've defined exact pixel padding and color hex values. What would be even better is to not define them. That is, make one sheet for the app that we always refer to called "building blocks" with all the colors[0] and paddings and other rhythms on it. Whenever we see redlines, we'd assume it'd be something obvious from that recipe sheet unless specified otherwise. Maybe you're already doing this and I should just be using the Google Material guidelines directly but I didn't want to assume in this case because Google's guidelines are a bit large, in flux, and lacking in some places.
  3. Were you wanting the Wiktionary buttons to have a stock ripple effect or the translucent effect like link preview?
  4. I forgot that Wiktionary had images. I assume that the Wiktionary icon is expected to just be the lead image type thing? For example, the "dog" definition would show a Labrador retriever.
  5. I think you or Dmitry mentioned that the Wiktionary definition would be nonmodal, slide in like link previews, and try to avoid obscuring the highlight itself by appearing on the top or bottom of the screen. If there's additional behavior desirable it'd be great to define that.
  6. For the font, is this the stock Roboto font or something custom? I _think_ it would be better to specify the font in points. It's actually flagged as a warning in the dev tools to specify fonts in pixels since that effectively freezes the font size even for the visually impaired. In some cases, you might deliberately specify fixed font sizes but I think those should be rare.
  7. I forgot that many words will have sizable content! Just to confirm, tapping "full definition" is expected to take you to Wiktionary word article which is expected to look something like a Wikipedia article?
  8. Do we want to show whether the word is a noun / verb / etc? What about pluralization and IPA? Is that secondary text?
  9. Do we want a dismiss button on the Wiktionary sheet since it's nonmodal or will users know to swipe that away when they're done?
  10. Do we want to limit how much we show? For example, the noun "dog" has a list of 12 definitions.

Thanks for all the effort you put into these. They look really sharp and I strongly appreciate the chance to review them before starting!

[0] https://www.google.com/design/spec/style/color.html#color-color-palette

@Niedzielski

What do these look like in landscape? Do they stretch? Are they more narrow? Do they have a target percentage width and height and max pixel width and height?

They should have the same behavior as current link previews, constrained by width. True we want initial height constraints and maximum scroll height constraints, I'll add that.

I love that you've defined exact pixel padding and color hex values. What would be even better is to not define them. That is, make one sheet for the app that we always refer to called "building blocks" with all the colors[0] and paddings and other rhythms on it. Whenever we see redlines, we'd assume it'd be something obvious from that recipe sheet unless specified otherwise. Maybe you're already doing this and I should just be using the Google Material guidelines directly but I didn't want to assume in this case because Google's guidelines are a bit large, in flux, and lacking in some places.

I agree! I'll work on building that this quarter.

Were you wanting the Wiktionary buttons to have a stock ripple effect or the translucent effect like link preview?

I'll add behavior specific to Wiktionary here T114949, then one we have it all settled I'll come back to this and add more overview of behaviors for all the sheets

I forgot that Wiktionary had images. I assume that the Wiktionary icon is expected to just be the lead image type thing? For example, the "dog" definition would show a Labrador retriever.

I don't think many have images, and we can use an icon here.

I think you or Dmitry mentioned that the Wiktionary definition would be nonmodal, slide in like link previews, and try to avoid obscuring the highlight itself by appearing on the top or bottom of the screen. If there's additional behavior desirable it'd be great to define that.

Lets discuss this and all the following wiktionary stuff here T114949

For the font, is this the stock Roboto font or something custom? I _think_ it would be better to specify the font in points. It's actually flagged as a warning in the dev tools to specify fonts in pixels since that effectively freezes the font size even for the visually impaired. In some cases, you might deliberately specify fixed font sizes but I think those should be rare.

Sorry not using Roboto here but yes we should keep the standard type. That will be a good thing to add to overall design spec!