Page MenuHomePhabricator

Combo box

Authored By
violetto, May 5 2015
Referenced Files
F161683: sizeGuide.png
May 7 2015, 8:40 PM
F161425: Screenshot 2015-05-06 20.06.17.png
May 7 2015, 3:07 AM
F161427: Screenshot 2015-05-06 20.08.03.png
May 7 2015, 3:07 AM
F161422: Screenshot 2015-05-06 20.04.28.png
May 7 2015, 3:03 AM
F161138: Screen_Shot_2015-05-06_at_3.30.09_PM.png
May 6 2015, 10:26 AM
F161139: Screen_Shot_2015-05-06_at_3.30.15_PM.png
May 6 2015, 10:26 AM
F161137: Screen_Shot_2015-05-06_at_3.30.05_PM.png
May 6 2015, 10:26 AM
F160602: Screenshot_2015-05-04_20.21.17.png
May 5 2015, 3:20 AM

Mock History

Current Revision1

Event Timeline

I'll be supplying more details soon

Looking at M33, and then this I think you've got the labeling for hover, and focus mixed up.

Inline Comments

We have been using a blue outline on :focus. Why are keeping this different?

We haven't used the blue outline for :hover in any other element. Any reason we are making this change?

Started implementing parts of this in OOUI -

Screen_Shot_2015-05-06_at_3.30.05_PM.png (72×353 px, 9 KB)
Screen_Shot_2015-05-06_at_3.30.09_PM.png (72×348 px, 9 KB)
Screen_Shot_2015-05-06_at_3.30.15_PM.png (234×346 px, 16 KB)

While doing so I realized that I was implementing DropDownWidget and not ComboBoxWidget
@violetto, could you please add specs for that in this pholio itself? I'll start work on ComboBoxWidget as well.

About blue outline on hover for textfield:

Remember how we have this on focus?

Screenshot 2015-05-06 20.06.17.png (52×497 px, 13 KB)

It'll be more consistent if on hover it becomes blue with 1px border and then change to 2px on focus. So the change of color isn't jarring.

Screenshot 2015-05-06 20.08.03.png (109×486 px, 21 KB)

For every single text field that we have going forward, they will adopt the same blue style.

Inline Comments

sizeGuide.png (192×239 px, 11 KB)