Page MenuHomePhabricator

Dropdown menu
OpenPublic

Authored By
violetto, May 7 2015
Referenced Files
F1496774: Screenshot 2015-08-14 14.30.26.png
Aug 14 2015, 9:31 PM
F163895: dropdown.mov
Jun 8 2015, 10:20 AM
F174883: pasted_file
Jun 5 2015, 12:16 AM
F174885: pasted_file
Jun 5 2015, 12:16 AM
F161679: sizeGuide.png
May 7 2015, 8:39 PM
F161675: Screenshot 2015-05-07 13.33.26.png
May 7 2015, 8:38 PM

Mock History

Current Revision
1

Event Timeline

violetto added subscribers: Prtksxna, Volker_E.
violetto added inline comment(s).
Inline Comments

sizeGuide.png (192×239 px, 11 KB)

Just a note that in bb9c9c4f6a2fca6aed0e671e904e469d57da5f34 we changed the image used for the little downward arrow in this widget in OOUI.

Old:

pasted_file (79×669 px, 3 KB)

Current:

pasted_file (79×669 px, 3 KB)

Do you think we should change it back? These mockups currently use the old one, but I guess that's just because they were created before that change.

On regular menus we're using the "Old" version downward arrow. On toolbars though, we're using the "Current" version of downward arrow to preserve some more space.

Implemented in https://gerrit.wikimedia.org/r/#/c/210299/

Please see F163895 and M62, should the focus state remain when the dropdown is open?

More generally, I think the inset-by-one-pixel-but-otherwise-identical-to-hover styling for the focus state should be revisited. I assumed it was a mistake rather than intentional design, and it's a little too subtle to achieve the meaning of 'focus' as is normally used (outward-gradiented blue highlight).

@Prtksxna, is there a way I could interact with the menu? I want to get a better idea on how it feels.

should the focus state remain when the dropdown is open?

Did you mean when a menu is currently in a focus state and then expanded, it still have focus state? If I understand correctly then it shouldn't have. Instead it will have a normal state, unless if any selection is hovered over (#EEE) or is currently selected (#D8E6FE).

@Prtksxna, is there a way I could interact with the menu? I want to get a better idea on how it feels.

Look for DropdownWidget in https://doc.wikimedia.org/oojs-ui/master/demos/#widgets-mediawiki-vector-ltr

Did you mean when a menu is currently in a focus state and then expanded, it still have focus state?

Yep, the menu has focus when its expanded.

If I understand correctly then it shouldn't have.

The browser needs to give it focus to allow for keyboard controls.

@Prtksxna wouldn't the currently focused component be indicated by the expanded dropdown? I think that's a big enough sign that a dropdown is in focus.

@Prtksxna wouldn't the currently focused component be indicated by the expanded dropdown? I think that's a big enough sign that a dropdown is in focus.

It sure is, I agree with you. I was just saying that it has focus, I didn't mean to say that thus we must show it explicitly (over and above an open drop down).
The focus state is important though when the drop down isn't open but the widget is still in focus.