Page MenuHomePhabricator
Paste P3063

Log from code review office hour (E179)
ActivePublic
Actions

Authored by • RobLa-WMF on May 12 2016, 9:38 PM.
Project Tags
None
Referenced Files
F4002625: Log from code review office hour (E179)
May 12 2016, 9:38 PM
Subscribers
None
[19:53:23] <Luke081515> ok, so we can start in 7 minutes. Everyone here?
[19:57:30] * twentyafterfour is here
[19:57:32] <twentyafterfour> ;)
[20:00:06] <addshore> woo
[20:00:10] <twentyafterfour> Hello
[20:00:43] <Luke081515> guess the beginning is the most difficult part ;) how we start?
[20:01:14] <twentyafterfour> Luke081515: we start with the list of patches on E179
[20:01:19] <Luke081515> ok
[20:01:23] <jdlrobson> Who's here?
[20:01:28] <Ricordisamoa> o/
[20:01:55] <twentyafterfour> @bmansurov WikiLabels beta feature https://gerrit.wikimedia.org/r/#/c/264415/
[20:01:57] <twentyafterfour> @mmodell T125678: extension-list should live in the mediawiki branch rather than mediawiki-config https://gerrit.wikimedia.org/r/#/c/287565/
[20:01:57] <stashbot> T125678: extension-list should live in the mediawiki branch rather than mediawiki-config - https://phabricator.wikimedia.org/T125678
[20:01:59] <twentyafterfour> @Aklapper +more T37378: Support multiple collations at the same time https://gerrit.wikimedia.org/r/#/c/87288/
[20:01:59] <stashbot> T37378: Support multiple collations at the same time - https://phabricator.wikimedia.org/T37378
[20:02:01] <twentyafterfour> @Ricordisamoa T68974: Provide a standard way to get the target of a redirect page https://gerrit.wikimedia.org/r/168282
[20:02:01] <stashbot> T68974: Provide a standard way to get the target of a redirect page - https://phabricator.wikimedia.org/T68974
[20:02:03] <twentyafterfour> @Paladox Fix using $GLOBALS in database updater https://gerrit.wikimedia.org/r/#/c/227238/
[20:02:05] <twentyafterfour> @TheDJ Protection: Rework on how cascade-protection are applied to files https://gerrit.wikimedia.org/r/#/c/233207/
[20:02:35] <twentyafterfour> Those are the ones I identified from the comments. Feel free to also propose others here in the channel
[20:02:36] <Ricordisamoa> my patch has been merged by Legoktm
[20:02:41] <twentyafterfour> yay!
[20:03:00] <twentyafterfour> Preemptive success.
[20:03:02] <paladox> twentyafterfour: Ive updated patch i proposed due to legoktm -2 since we are moving to extensionr registration now.
[20:03:11] <grrrit-wm> (03PS1) 10Aaron Schulz: Make User::isBot() also check the "bot" right for sanity [core] - 10https://gerrit.wikimedia.org/r/288466
[20:03:46] * bmansurov is here
[20:03:46] <MGChecker> My patches by some rason didn't get an entry in the list
[20:03:46] <paladox> Ive changed it to Make VisualEditor support truly optional https://gerrit.wikimedia.org/r/#/c/279957/
[20:03:47] <Luke081515> ok, so we need to motivate the +2 guys to start ;)
[20:04:15] <twentyafterfour> MGChecker: apologies
[20:04:31] <twentyafterfour> link please?
[20:04:44] <Luke081515> https://phabricator.wikimedia.org/E179#1937
[20:04:50] <twentyafterfour> https://gerrit.wikimedia.org/r/#/c/286688/
[20:04:52] <twentyafterfour> https://gerrit.wikimedia.org/r/#/c/286282/
[20:04:58] <twentyafterfour> sorry about that, it was my mistake
[20:05:13] <MGChecker> oh, i thought I did anything wrong :$
[20:05:19] <grrrit-wm> (03CR) 10TheDJ: [C: 04-1] "This is also one of those changes that will definitely need a mention in the RELEASE-NOTES-1.28" [core] - 10https://gerrit.wikimedia.org/r/233207 (https://phabricator.wikimedia.org/T24521) (owner: 10Zhuyifei1999)
[20:05:28] <twentyafterfour> so I don't know if we should divide these up or each just grab one?
[20:05:32] <jdlrobson> I'm starting with taking a pass through https://gerrit.wikimedia.org/r/#/q/age:2year,n,z
[20:05:40] <twentyafterfour> jdlrobson: cool
[20:05:51] * greg-g waves
[20:06:06] <twentyafterfour> jdlrobson: though for people who are actually here to answer questions, we should look at their patches before stale ones
[20:06:22] <twentyafterfour> hi Greg
[20:06:25] <grrrit-wm> (03PS2) 10Jdlrobson: (bug 35607) Fix OXML type detection [core] - 10https://gerrit.wikimedia.org/r/70830 (https://phabricator.wikimedia.org/T37607) (owner: 10VitaliyFilippov)
[20:06:55] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "This needs a rebase. @VitaliyFilippov are you still working on this patch?" [core] - 10https://gerrit.wikimedia.org/r/70830 (https://phabricator.wikimedia.org/T37607) (owner: 10VitaliyFilippov)
[20:06:58] <grrrit-wm> (03PS9) 10Ricordisamoa: [WIP] enable native client-side rendering of SVG images [core] - 10https://gerrit.wikimedia.org/r/182332 (https://phabricator.wikimedia.org/T5593)
[20:07:08] <jdlrobson> where can i find awight
[20:07:34] <twentyafterfour> so MGChecker since you spoke up I'm taking a look at your patches
[20:07:43] <Luke081515> jdlrobson: Try to invite him ;) channel has +g so everybody is able to
[20:07:44] <MGChecker> Oh, thank you!
[20:07:45] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] (bug 35607) Fix OXML type detection [core] - 10https://gerrit.wikimedia.org/r/70830 (https://phabricator.wikimedia.org/T37607) (owner: 10VitaliyFilippov)
[20:07:47] <jdlrobson> twentyafterfour: sure if someone doesn't have a reviewer and has a mostly frontend patch they should interrupt me and ill look at that too :)
[20:07:58] <twentyafterfour> cool
[20:08:03] <paladox> jdlrobson: #wikimedia-operation
[20:08:17] <Luke081515> *operations
[20:08:41] <paladox> Oh for me it is operation
[20:09:19] <jdlrobson> Anyone know much about MediaFunctions or SimpleSecurity extensions?
[20:09:35] <jdlrobson> Also BookManagerv2 ?
[20:09:49] <Luke081515> I used SimpleSecurty a bit, but I don't know much
[20:10:27] <addshore> If they are small patches I'll hapilly take a quick look jdlrobson
[20:10:43] <addshore> but I may also be about to dash!
[20:10:47] <jdlrobson> addshore: they are very old ones
[20:10:51] <jdlrobson> i'll add you as reviewer
[20:11:11] <addshore> do they rebase cleanly? :P
[20:11:37] <jdlrobson> addshore some don't but i can rebase them if they need a rebase
[20:11:50] <jdlrobson> i'd rather get them merged/abandoned then leave them hanging around
[20:13:46] <grrrit-wm> (03Abandoned) 10Ricordisamoa: [WIP] enable native client-side rendering of SVG images [core] - 10https://gerrit.wikimedia.org/r/182332 (https://phabricator.wikimedia.org/T5593) (owner: 10Ricordisamoa)
[20:14:02] <addshore> oh my god my IDE is screaming at me
[20:15:22] <grrrit-wm> (03CR) 1020after4: [C: 031] "looks good to me but I don't have a test environment. Should we merge this and try to catch fallout on beta if there is any? It seems rela" [core] - 10https://gerrit.wikimedia.org/r/286688 (https://phabricator.wikimedia.org/T101309) (owner: 10MGChecker)
[20:16:15] <andre47> jdlrobson: Bookmanagerv2 is very dead. tried several times to contact maintainers, but unsuccessful
[20:16:27] <twentyafterfour> anyone see a reason not to merge https://gerrit.wikimedia.org/r/#/c/286688/4 ?
[20:16:37] <jdlrobson> andre47: we should just abandon that patchset then.
[20:16:44] <jdlrobson> What about Moodbar - what's happening there? https://gerrit.wikimedia.org/r/#/c/49471/
[20:16:52] <jdlrobson> twentyafterfour: loookinnggg
[20:17:01] <thedj> twentyafterfour: looking
[20:17:15] <jdlrobson> thedj: are you able to test it?
[20:17:18] <jdlrobson> i can review the code
[20:17:37] <Luke081515> I tested that change at my labs instance, a wiki cluster with 10 wikis. But if you want to test again ;)
[20:18:30] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 032] TitleFormatter: Match Title behavior for non-existent namespaces [core] - 10https://gerrit.wikimedia.org/r/288445 (owner: 10Legoktm)
[20:18:50] <twentyafterfour> Luke081515: you tested which one?
[20:18:52] <andre47> jdlrobson: yes we should, with an explanation. cf https://www.mediawiki.org/wiki/Gerrit/Inactive_projects
[20:18:58] <Luke081515> https://gerrit.wikimedia.org/r/#/c/286688/
[20:19:02] <Luke081515> see my +1 comment ;)
[20:19:16] * andre47 slow typing, on a phone. sorry
[20:19:24] <jdlrobson> andre47: on it!
[20:19:32] <andre47> thx
[20:19:41] <Ricordisamoa> Hey there, https://gerrit.wikimedia.org/r/284848 is trivial
[20:19:47] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 032] LinkCache: Use LinkTarget instead of Title [core] - 10https://gerrit.wikimedia.org/r/285761 (owner: 10Legoktm)
[20:20:08] <Ricordisamoa> it isn't that old though
[20:20:21] <grrrit-wm> (03PS166) 10Gergő Tisza: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie)
[20:20:24] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 032] Parser tests: Also register namespace 101 to accompany 100 [core] - 10https://gerrit.wikimedia.org/r/288446 (owner: 10Legoktm)
[20:20:33] <twentyafterfour> Luke081515: thanks, MGChecker: I'm gonna merge it
[20:20:42] <twentyafterfour> Ricordisamoa: it doesn't need to be old
[20:20:45] <addshore> jdlrobson: I'd be happy to merge half of the simple dsecurity patch :p
[20:20:49] <twentyafterfour> this is about doing code review, not just old patches
[20:21:32] <grrrit-wm> (03PS167) 10Gergő Tisza: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie)
[20:21:47] <addshore> must dash now though :(
[20:22:51] <grrrit-wm> (03CR) 10Gergő Tisza: "PS 166: manual rebase" [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie)
[20:23:03] <jdlrobson> twentyafterfour: thedj i'm happy to merge https://gerrit.wikimedia.org/r/#/c/286688/ if you have no complaints
[20:23:12] <grrrit-wm> (03PS113) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277)
[20:23:24] <grrrit-wm> (03CR) 1020after4: [C: 031] "This looks good to me. It seems that previous concerns have been addressed?" [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker)
[20:23:27] <grrrit-wm> (03CR) 1020after4: [C: 032] Split editcascadeprotected permission from protect permission [core] - 10https://gerrit.wikimedia.org/r/286688 (https://phabricator.wikimedia.org/T101309) (owner: 10MGChecker)
[20:23:33] <thedj> jdlrobson: i'm ok too
[20:23:44] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Split editcascadeprotected permission from protect permission [core] - 10https://gerrit.wikimedia.org/r/286688 (https://phabricator.wikimedia.org/T101309) (owner: 10MGChecker)
[20:23:46] <bmansurov> I've updated my patch: https://gerrit.wikimedia.org/r/#/c/264415/9
[20:24:01] <twentyafterfour> I +2'd 286688 just now ;)
[20:24:04] <bmansurov> https://gerrit.wikimedia.org/r/#/c/264415/ rather
[20:24:21] <Luke081515> gate-and-submit has actually 4 patches
[20:24:37] <twentyafterfour> bmansurov: looking
[20:24:42] <bmansurov> thanks!
[20:26:45] <paladox> Hi could someone abandon https://gerrit.wikimedia.org/r/#/c/218428/ please. That was already done plus the repo was split into a different extension.
[20:26:46] <MGChecker> If you wanna look for my second patch too: https://gerrit.wikimedia.org/r/#/c/286282/
[20:27:25] <paladox> twentyafterfour or jdlrobson ^^
[20:27:27] <Luke081515> MGChecker: Take a look at grrrit from 22:23
[20:27:32] <MGChecker> I see
[20:27:56] <jdlrobson> is that okay with legoktm paladox ?
[20:28:08] <jdlrobson> bmansurov: gave you some feedback
[20:28:17] <bmansurov> jdlrobson: thanks
[20:28:42] <grrrit-wm> (03CR) 10TheDJ: "And needs some double checking now that https://gerrit.wikimedia.org/r/#/c/286688/ was merged" [core] - 10https://gerrit.wikimedia.org/r/233207 (https://phabricator.wikimedia.org/T24521) (owner: 10Zhuyifei1999)
[20:29:05] <paladox> jdlrobson: Not sure but that repo dosen't contain BoilerPlate in https://phabricator.wikimedia.org/diffusion/EXAM/repository/master/ any more
[20:29:08] <paladox> its now at https://phabricator.wikimedia.org/diffusion/EBOP/repository/master/
[20:29:18] <paladox> https://phabricator.wikimedia.org/diffusion/EBOP/browse/master/extension.json
[20:29:32] <andre47> (and for the records, about Bookmanagerv2, see https://phabricator.wikimedia.org/T117105 )
[20:30:14] <grrrit-wm> (03CR) 10MGChecker: "Yes, I did." [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker)
[20:30:42] <twentyafterfour> I voted +1 on 286282, but I think we can go ahead and merge that one too? seems like almost the same changes as 286688
[20:31:27] <grrrit-wm> (03CR) 10Jdlrobson: [C: 031] "Looks good but I need to test..." [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker)
[20:31:37] <paladox> jdlrobson and twentyafterfour and thedj would you be able to take a look at https://gerrit.wikimedia.org/r/#/c/258783/ and https://gerrit.wikimedia.org/r/#/c/259061/ please
[20:31:40] <paladox> There both linked
[20:31:54] <grrrit-wm> (03PS19) 10Paladox: Allow the signature button wikitext to be overridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191)
[20:32:42] <jdlrobson> paladox: testing
[20:33:03] <paladox> jdlrobson: Thanks.
[20:33:18] <jdlrobson> paladox: only because you have too many patches open :)
[20:33:18] <grrrit-wm> (03Merged) 10jenkins-bot: TitleFormatter: Match Title behavior for non-existent namespaces [core] - 10https://gerrit.wikimedia.org/r/288445 (owner: 10Legoktm)
[20:33:25] <grrrit-wm> (03Merged) 10jenkins-bot: LinkCache: Use LinkTarget instead of Title [core] - 10https://gerrit.wikimedia.org/r/285761 (owner: 10Legoktm)
[20:33:29] <grrrit-wm> (03Merged) 10jenkins-bot: Parser tests: Also register namespace 101 to accompany 100 [core] - 10https://gerrit.wikimedia.org/r/288446 (owner: 10Legoktm)
[20:34:04] <twentyafterfour> paladox: :P
[20:34:10] <paladox> jdlrobson: Yep and sorry about that. I didn't realise that i had that many open. I went through a few yesturday and abadoned some still need to go through the rest.
[20:35:34] <MGChecker> I really like this concept :)
[20:35:58] <grrrit-wm> (03CR) 1020after4: [C: 031] "untested but this seems safe enough." [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox)
[20:37:06] <grrrit-wm> (03Merged) 10jenkins-bot: Split editcascadeprotected permission from protect permission [core] - 10https://gerrit.wikimedia.org/r/286688 (https://phabricator.wikimedia.org/T101309) (owner: 10MGChecker)
[20:37:09] <Luke081515> so who has +2 too and isn't voiced yet? I'm spendable today ;)
[20:38:11] <jdlrobson> paladox: so... i'm trying to override the message
[20:38:15] <grrrit-wm> (03CR) 10Awight: [C: 04-2] WIP: New hook to instrument page save failures [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Awight)
[20:38:22] <jdlrobson> but it's not rendering my new message. Have I misunderstood the tasl?
[20:38:28] <grrrit-wm> (03CR) 10Awight: [C: 04-2] WIP: Use the parentRevId for more atomic editing [core] - 10https://gerrit.wikimedia.org/r/94584 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight)
[20:38:54] <paladox> jdlrobson I think it overides --
[20:39:05] <paladox> the -- that goes in front of ~~~~
[20:39:16] <andre47> paladox: did overwriting work locally for you when testing?
[20:39:16] <jdlrobson> oh ignore me
[20:39:18] <jdlrobson> it's the toolbar right?
[20:39:24] <andre47> ah
[20:39:30] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Allow the signature button wikitext to be overridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox)
[20:39:45] <paladox> andre47 haven't tested yet.
[20:40:21] <twentyafterfour> Luke081515: did you also test https://gerrit.wikimedia.org/r/#/c/286282/ ? I don't have a proper test environment set up right now
[20:40:36] <Luke081515> I can test it now, but I need a moment
[20:40:45] <paladox> jdlrobson the only bit im confused about is https://gerrit.wikimedia.org/r/#/c/258783/20/modules/jquery.wikiEditor.toolbar.config.js i doint know where i got to do mw.conf
[20:40:45] <paladox> ig.get( 'mw.msg.wikieditor' )
[20:40:49] <paladox> and thanks for merging
[20:40:59] <andre47> paladox: i hope you mean 'right now' and not 'never tested that patch'? :)
[20:41:03] <Luke081515> I will give +1 from my side, if my tests are finished ;)
[20:41:23] <paladox> andre47, im not sure if i tested but i haven't tested right now.
[20:41:43] <paladox> Im going to test the wikieditor one now.
[20:41:48] <jdlrobson> paladox: https://gerrit.wikimedia.org/r/#/c/258783/20 looks fine but I'm wondering what happens for anonymous users?
[20:41:54] <jdlrobson> Surely this will cache?
[20:42:06] <jdlrobson> and all anons will have the same signature?
[20:42:25] <jdlrobson> i'm not too familiar with the WikiEditor extension
[20:42:38] <jdlrobson> i'd suggest poking catrope
[20:42:44] <paladox> jdlrobson: I will go test that logged in and logged out
[20:42:52] <andre47> paladox: ok. in general, if you have not tested a patch you submit, please clearly state so in a gerrit comment. makes it easier for others to judge how closely to look at the code. thanks :)
[20:43:02] <jdlrobson> paladox: you'll need to vary your ip as well
[20:43:09] <jdlrobson> and turn on some kind of html caching
[20:43:32] <paladox> jdlrobson: Oh im not sure how to do html caching but i used cloudflare
[20:43:39] <paladox> which caches
[20:45:00] <grrrit-wm> (03Abandoned) 10Jdlrobson: [WIP] Add mobile target to MultimediaViewer dependencies [core] - 10https://gerrit.wikimedia.org/r/116154 (owner: 10JGonera)
[20:45:04] <grrrit-wm> (03PS5) 10Aaron Schulz: Support key versioning in WANObjectCache [core] - 10https://gerrit.wikimedia.org/r/288347
[20:45:26] <grrrit-wm> (03CR) 10Awight: [C: 04-2] WIP Add tests to exercise a language bug in DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/57018 (https://bugzilla.wikimedia.org/46766) (owner: 10Awight)
[20:46:43] <jdlrobson> Good news - only 2 patches over 2 years old do not have reviews! https://gerrit.wikimedia.org/r/#/q/age:2year+label:Code-Review%253D0,n,z
[20:46:51] <grrrit-wm> (03CR) 10Awight: [C: 04-2] WIP split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight)
[20:47:02] <jdlrobson> Who maintains pybot ?
[20:47:30] <grrrit-wm> (03PS7) 10Jdlrobson: mediawiki.errorLogger: Add error id and manual reporting [core] - 10https://gerrit.wikimedia.org/r/199789 (https://phabricator.wikimedia.org/T89384) (owner: 10Gergő Tisza)
[20:48:00] <Ricordisamoa> jdlrobson: https://labix.org/pybot
[20:48:08] <Ricordisamoa> ?
[20:48:11] <jdlrobson> Ricordisamoa: there are a bunch of open patches for pybot
[20:48:35] <jdlrobson> pywikibot sorry :)
[20:48:35] <jdlrobson> https://gerrit.wikimedia.org/r/#/q/status:open+project:pywikibot/core,n,z
[20:48:37] <Ricordisamoa> jdlrobson: you mean pywikibot?
[20:48:45] <andre47> ah
[20:48:48] <andre47> #pywikibot - several folks like jayvdb, xzise, amir etc
[20:49:01] <grrrit-wm> (03CR) 10Awight: [C: 04-2] [WIP] Helper to get a page's revision ID at a given time [core] - 10https://gerrit.wikimedia.org/r/201929 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight)
[20:49:09] <grrrit-wm> (03CR) 10Awight: [C: 04-2] WIP Refactor TitleSecurity to eliminate state [core] - 10https://gerrit.wikimedia.org/r/203287 (https://phabricator.wikimedia.org/T386) (owner: 10Awight)
[20:49:13] <grrrit-wm> (03CR) 10Awight: [C: 04-2] [WIP] Introduce parentrevid parameter in the API [core] - 10https://gerrit.wikimedia.org/r/204713 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight)
[20:49:19] <grrrit-wm> (03CR) 10Awight: [C: 04-2] WIP Compatibility to guess the parentRevId from legacy timestamp [core] - 10https://gerrit.wikimedia.org/r/204714 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight)
[20:49:48] <Ricordisamoa> jdlrobson: I own some of them but development has slowed down, jayvdb is to blame :P
[20:50:00] <robla> https://www.mediawiki.org/wiki/Project:Pywikibot
[20:50:10] <grrrit-wm> (03CR) 10Awight: [C: 04-2] [WIP] Version number indicates we are on the fundraising branch [core] (fundraising/REL1_23) - 10https://gerrit.wikimedia.org/r/209856 (owner: 10Awight)
[20:50:15] <grrrit-wm> (03PS2) 10Brian Wolff: Remove support for $wgWellFormedXml=false [core] - 10https://gerrit.wikimedia.org/r/286495
[20:50:26] <jdlrobson> Ricordisamoa: would be good to organise a clean up day!
[20:50:28] <grrrit-wm> (03CR) 10Brian Wolff: "For reference: https://lists.wikimedia.org/pipermail/wikitech-l/2016-May/085461.html" [core] - 10https://gerrit.wikimedia.org/r/286495 (owner: 10Brian Wolff)
[20:51:24] <bawolff> Anyone want to review https://gerrit.wikimedia.org/r/#/c/143835/ [Special:Wantedfiles not sucking]
[20:52:01] <grrrit-wm> (03Merged) 10jenkins-bot: Allow the signature button wikitext to be overridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox)
[20:52:38] <bawolff> Or perhaps review https://gerrit.wikimedia.org/r/#/c/286495 if you think https://lists.wikimedia.org/pipermail/wikitech-l/2016-May/085461.html was in favour of it (Nobody was outright opposed, but nobody said yes either)
[20:53:53] <robla> ooo bawolff, would 143835 fix the bug from 2006?
[20:54:29] <robla> bug from 2006: https://phabricator.wikimedia.org/T8220
[20:54:32] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Fix 'asciiAlphabetLiteral' definition [core] - 10https://gerrit.wikimedia.org/r/288329
[20:54:35] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] mediawiki.errorLogger: Add error id and manual reporting [core] - 10https://gerrit.wikimedia.org/r/199789 (https://phabricator.wikimedia.org/T89384) (owner: 10Gergő Tisza)
[20:54:37] <robla> not that I know anything abou tthat bug
[20:54:38] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Meh, okay." [core] - 10https://gerrit.wikimedia.org/r/288329 (owner: 10Bartosz Dziewoński)
[20:54:45] <grrrit-wm> (03PS3) 10Bartosz Dziewoński: mediawiki.jqueryMsg: Fix 'asciiAlphabetLiteral' definition [core] - 10https://gerrit.wikimedia.org/r/288329
[20:54:58] * bawolff quickly reads that bug again
[20:55:06] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "It's a year later and this has turned into a nasty rebase. How do we want to proceed?" [core] - 10https://gerrit.wikimedia.org/r/206642 (owner: 10Jack Phoenix)
[20:55:45] * robla had only skimmed the comment and saw the four digit bug number, and was intrigued
[20:56:10] <jdlrobson> bawolff: happy to take a look
[20:56:13] <paladox> jdlrobson: If you change sig-text message it affects everyone and that is what the patch is
[20:56:19] <bawolff> I believe it should fix that bug
[20:56:25] <paladox> So you can change how -- is shown per wiki.
[20:56:42] <paladox> Ive tested using https://en.random-wikisaur.tk/index.php?title=Talk:Main_Page&action=edit
[20:56:50] <jdlrobson> paladox: i know what it does but you are not reassuring my concerns around the caching. I'd suggest you talk to someone in editing who knows that extension well. I'm not going to merge it :)
[20:56:54] <bawolff> that's the problem with patches from 2 years ago. I slightly forget what I actually did ;)
[20:56:59] <Luke081515> twentyafterfour: I tested 286282, and I get this message every time after login:
[20:57:02] <Luke081515> Argument 2 passed to EchoHooks::onOutputPageCheckLastModified() must be an instance of OutputPage, undefined variable given
[20:57:06] <paladox> jdlroboson: Ok
[20:57:39] <twentyafterfour> MGChecker: ^
[20:57:51] <robla> bawolff: :-)
[20:58:02] <grrrit-wm> (03CR) 10Luke081515: "check zend" [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker)
[20:58:13] <bawolff> jdlrobson: thanks
[20:58:24] <Luke081515> let's take a look if zend find something
[20:58:28] <Luke081515> *finds
[20:58:48] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Remove support for $wgWellFormedXml=false [core] - 10https://gerrit.wikimedia.org/r/286495 (owner: 10Brian Wolff)
[20:59:00] <grrrit-wm> (03CR) 10BryanDavis: [C: 031] "Two small documentation nits inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/288452 (owner: 10Ori.livneh)
[20:59:03] <MGChecker> I have no idea how this error can happen, my patch even hasn't anything to do with Echo...
[20:59:27] <jdlrobson> bawolff: i have to setup GloblalUsage extension...
[20:59:31] <Luke081515> I'm wondering too, but without this patch I don't get any error, I tried it about six times
[21:00:20] <bawolff> jdlrobson: to truely see it in action, you have to actually have two wikis going, which is a pain to set up locally
[21:01:12] <bawolff> hopefully $wgConf is better documented then when I tried to do that. I remember it was frustrating...
[21:01:19] <jdlrobson> bawolff: yeh... that's not gonna happen in the next 5 mins I have :/ Looking at the code though it looks fine. I can give it a +1 but that's not as helpful I know :/
[21:01:59] <bawolff> No worries, I understand
[21:02:15] <jdlrobson> andre47: is Moodbar still maintained?
[21:02:20] <bawolff> vagrant might possibly have a mode for GlobalUsage (I don't use vagrant so I don't really know)
[21:03:26] <andre47> jdlrobson: maintained... well, fixing total breakage pribably still happens as it's still deployed iirc but nothing else
[21:04:13] <andre47> so its not total abandonware but very close to that
[21:05:36] <paladox> jdlrobson: Hi would you be able to review https://gerrit.wikimedia.org/r/#/c/279957/ please. Its flow. I tested it initially but as some reviews were done i haven't tested it with the latest patch.
[21:07:26] <andre47> jdlrobson: plan is to undeploy moidbar but: community consensus. see https://phabricator.wikimedia.org/T131340
[21:11:07] <grrrit-wm> (03PS14) 10MGChecker: Split off permission to delete tags from managechangetags permission [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811)
[21:11:58] <twentyafterfour> weird. Luke081515 + MGChecker: onOutputPageCheckLastModified doesn't even exist in EchoHooks
[21:12:25] <MGChecker> wtf
[21:12:52] <Luke081515> maybe we should use another test enviourment, my one has a lot of extensions
[21:14:01] <twentyafterfour> Luke081515: yeah I can't quite see how that would be caused by this extension but it's possible
[21:18:57] <Luke081515> let's take a look at ps 14
[21:20:19] <Luke081515> twentyafterfour: strange, I'm not able to reporcude the error message anymore. going to make the "real" tests now ;)
[21:22:12] <Luke081515> jdlrobson: In contrast to SWAT hours, you can go on with reviewing even if the hour is over (if you have time) ;)
[21:26:30] <jdlrobson> Luke081515: i've unfortunately got other stuff to do, but that felt like progress.
[21:26:36] <Luke081515> ok :)
[21:27:14] <jdlrobson> twentyafterfour: i sent a couple of mails to wikitech
[21:27:48] <jdlrobson> i'd love to get to a place we can use https://gerrit.wikimedia.org/r/#/q/(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2)),n,z as the basis for what needs reviewing
[21:29:37] <grrrit-wm> (03CR) 10Luke081515: [C: 031] "Tested, confirmed that it works, tested:" [core] - 10https://gerrit.wikimedia.org/r/286282 (https://phabricator.wikimedia.org/T133811) (owner: 10MGChecker)
[21:29:51] <grrrit-wm> (03CR) 10Anomie: Fix i18n message parameter for 'keep me logged in' days. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza)
[21:29:51] <Luke081515> twentyafterfour: ^ Works now, you can merge now ;)
[21:30:09] <Luke081515> jdlrobson: or you can if you have a bit time ;)
[21:31:55] <twentyafterfour> Luke081515: I can
[21:32:01] <Luke081515> ok, thx
[21:32:54] <twentyafterfour> thanks to everyone who helped out, did reviews, etc.
[21:33:01] <twentyafterfour> I am quite happy with how things went today
[21:34:27] <Ricordisamoa> endmeeting
[21:34:55] <Luke081515> if this continues the next week, it was a good idea to do events like this ;)
[21:35:59] <grrrit-wm> (03PS3) 10Brian Wolff: Remove support for $wgWellFormedXml=false [core] - 10https://gerrit.wikimedia.org/r/286495
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits