Page MenuHomePhabricator
Paste P3672

php7cc warnings - see T120336
ActivePublic

Authored by Seb35 on Aug 9 2016, 8:27 AM.
-------------------------------------- Checked --------------------------------------
----- func_get_args? - args are possibly changed but it remains consistent -----
File: /srv/www/mediawiki/master/includes/import/WikiImporter.php
> Line 401: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
--> here the first arg $title can be modified by $title->getPrefixedText() which is a memoised function
----- func_get_args? - should be constant after analysis -----
File: /srv/www/mediawiki/master/includes/libs/jsminplus.php
> Line 1675: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
--> I didn’t deeply investigate, but even if the two first args are modified, the others (of interest) are not
File: /srv/www/mediawiki/master/tests/phpunit/includes/api/query/ApiQueryTestBase.php
> Line 43: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
----- func_get_args? - args unmodified until the function call -----
File: /srv/www/mediawiki/master/includes/logging/LogPage.php
> Line 262: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/exception/MWExceptionHandler.php
> Line 210: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/specials/SpecialImport.php
> Line 572: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/specials/SpecialEditWatchlist.php
> Line 103: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/specials/SpecialRunJobs.php
> Line 100: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/SiteConfiguration.php
> Line 587: Function argument(s) returned by "func_get_arg" might have been modified
func_get_arg($i);
File: /srv/www/mediawiki/master/includes/db/Database.php
> Line 981: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 2952: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/api/ApiAuthManagerHelper.php
> Line 380: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/GlobalFunctions.php
> Line 2286: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/tests/phpunit/MediaWikiTestCase.php
> Line 1455: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/tests/phpunit/maintenance/MaintenanceTest.php
> Line 83: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
----- func_get_args? - called at the beginning -----
File: /srv/www/mediawiki/master/includes/Block.php
> Line 124: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/media/MediaTransformOutput.php
> Line 307: Function argument(s) returned by "func_get_arg" might have been modified
func_get_arg(5);
> Line 309: Function argument(s) returned by "func_get_arg" might have been modified
func_get_arg(4);
File: /srv/www/mediawiki/master/includes/htmlform/HTMLForm.php
> Line 924: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/specialpage/SpecialPage.php
> Line 732: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/filerepo/ForeignDBViaLBRepo.php
> Line 91: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/filerepo/ForeignDBRepo.php
> Line 128: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/img_auth.php
> Line 192: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/GlobalFunctions.php
> Line 3052: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 3089: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
File: /srv/www/mediawiki/master/includes/libs/objectcache/MultiWriteBagOStuff.php
> Line 182: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
----- func_get_args? - called at the beginning, deprecated, with a wfDeprecated -----
File: /srv/www/mediawiki/master/includes/parser/CoreParserFunctions.php
> Line 97: Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
-------------------------------------- Backlog --------------------------------------
File: /srv/www/mediawiki/master/includes/debug/logger/monolog/AvroFormatter.php
> Line 170: Bitwise shift by 32 bits
($id & 1.8446744069414584E+19) >> 32;
File: /srv/www/mediawiki/master/includes/libs/MWMessagePack.php
> Line 100: Bitwise shift by 32 bits
($value & 1.8446744069414584E+19) >> 32;
> Line 133: Bitwise shift by 32 bits
$value >> 32;
File: /srv/www/mediawiki/master/includes/objectcache/SqlBagOStuff.php
> Line 489: Bitwise shift by 62 bits
1 \ 62;
File: /srv/www/mediawiki/master/includes/parser/Preprocessor_DOM.php
> Line 753: Possible object property creation during by-reference assignment
$this->accum =& $this->rootAccum;
> Line 797: Possible object property creation during by-reference assignment
$this->accum =& $this->rootAccum;
File: /srv/www/mediawiki/master/includes/Status.php
> Line 62: Possible object property creation during by-reference assignment
$this->value =& $this->sv->value;
> Line 63: Possible object property creation during by-reference assignment
$this->successCount =& $this->sv->successCount;
> Line 64: Possible object property creation during by-reference assignment
$this->failCount =& $this->sv->failCount;
> Line 65: Possible object property creation during by-reference assignment
$this->success =& $this->sv->success;
File: /srv/www/mediawiki/master/includes/cache/localisation/LocalisationCache.php
> Line 509: Possible array element creation during by-reference assignment
$this->data[$primaryCode] =& $this->data[$fallbackCode];
> Line 510: Possible array element creation during by-reference assignment
$this->loadedItems[$primaryCode] =& $this->loadedItems[$fallbackCode];
> Line 511: Possible array element creation during by-reference assignment
$this->loadedSubitems[$primaryCode] =& $this->loadedSubitems[$fallbackCode];
File: /srv/www/mediawiki/master/includes/parser/LinkHolderArray.php
> Line 64: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($nsLinks as &$entry) {
}
> Line 84: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($nsLinks as &$entry) {
}
File: /srv/www/mediawiki/master/includes/clientpool/RedisConnectionPool.php
> Line 321: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($serverConnections as $key => &$connection) {
}
> Line 420: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($serverConnections as $key => &$connection) {
}
File: /srv/www/mediawiki/master/includes/resourceloader/ResourceLoader.php
> Line 1299: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($module[2] as &$dependency) {
}
File: /srv/www/mediawiki/master/includes/skins/SkinTemplate.php
> Line 441: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($footerIconsBlock as &$footerIcon) {
}
> Line 1127: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($links as $key => &$link) {
}
File: /srv/www/mediawiki/master/includes/media/FormatMetadata.php
> Line 141: Possible adding to array on the last iteration of a by-reference foreach loop
$tags[$tag] = str_pad(intval($h[0] / $h[1]), 2, '0', STR_PAD_LEFT) . ':' . str_pad(intval($m[0] / $m[1]), 2, '0', STR_PAD_LEFT) . ':' . str_pad(intval($s[0] / $s[1]), 2, '0', STR_PAD_LEFT);
> Line 149: Possible adding to array on the last iteration of a by-reference foreach loop
$tags[$tag] = $this->getLanguage()->time($time);
> Line 167: Nested by-reference foreach loop, make sure there is no iteration over the same array
foreach ($vals as &$val) {
}
> Line 1833: Possible adding to array on the last iteration of a by-reference foreach loop
$arr[$sanitizedKey] = $arr[$key];
File: /srv/www/mediawiki/master/includes/session/PHPSessionHandler.php
> Line 140: Check that callbacks that are passed to "session_set_save_handler" and return false or -1 (if any) operate correctly
session_set_save_handler(self::$instance, true);
File: /srv/www/mediawiki/master/includes/search/SearchMssql.php
> Line 184: String containing number in hexadecimal notation
'0xEFBBBF';
> Line 204: String containing number in hexadecimal notation
'0xEFBBBF';
File: /srv/www/mediawiki/master/includes/db/DatabaseMysql.php
> Line 39: Removed function "mysql_query" called
mysql_query($sql, $conn);
> Line 41: Removed function "mysql_unbuffered_query" called
mysql_unbuffered_query($sql, $conn);
> Line 85: Removed function "mysql_pconnect" called
mysql_pconnect($realServer, $this->mUser, $this->mPassword, $connFlags);
> Line 88: Removed function "mysql_connect" called
mysql_connect($realServer, $this->mUser, $this->mPassword, true, $connFlags);
> Line 103: Removed function "mysql_set_charset" called
mysql_set_charset($charset, $conn);
> Line 115: Removed function "mysql_close" called
mysql_close($conn);
> Line 124: Removed function "mysql_insert_id" called
mysql_insert_id($conn);
> Line 132: Removed function "mysql_errno" called
mysql_errno($this->mConn);
> Line 134: Removed function "mysql_errno" called
mysql_errno();
> Line 144: Removed function "mysql_affected_rows" called
mysql_affected_rows($conn);
> Line 156: Removed function "mysql_select_db" called
mysql_select_db($db, $conn);
> Line 160: Removed function "mysql_free_result" called
mysql_free_result($res);
> Line 164: Removed function "mysql_fetch_object" called
mysql_fetch_object($res);
> Line 168: Removed function "mysql_fetch_array" called
mysql_fetch_array($res);
> Line 172: Removed function "mysql_num_rows" called
mysql_num_rows($res);
> Line 176: Removed function "mysql_num_fields" called
mysql_num_fields($res);
> Line 180: Removed function "mysql_fetch_field" called
mysql_fetch_field($res, $n);
> Line 184: Removed function "mysql_field_name" called
mysql_field_name($res, $n);
> Line 188: Removed function "mysql_field_type" called
mysql_field_type($res, $n);
> Line 192: Removed function "mysql_data_seek" called
mysql_data_seek($res, $row);
> Line 196: Removed function "mysql_error" called
mysql_error($conn);
> Line 196: Removed function "mysql_error" called
mysql_error();
> Line 202: Removed function "mysql_real_escape_string" called
mysql_real_escape_string($s, $conn);
> Line 208: Removed function "mysql_ping" called
mysql_ping($conn);
Checked 2275 files in 53.240 seconds

Event Timeline

Seb35 created this paste.Aug 9 2016, 8:27 AM
Seb35 edited the content of this paste. (Show Details)Aug 9 2016, 8:54 AM
Seb35 edited the content of this paste. (Show Details)Aug 9 2016, 8:57 AM
Seb35 edited the content of this paste. (Show Details)Aug 9 2016, 6:08 PM
Seb35 edited the content of this paste. (Show Details)Aug 9 2016, 6:16 PM
Seb35 added a comment.Aug 9 2016, 6:18 PM

I finished to check the warnings func_get_args? - nothing specific, documentation could sometimes be improved but code is not affected by this change (or not in a buggy manner).

It remains other warnings, I sorted them by category.

Seb35 edited the content of this paste. (Show Details)Aug 9 2016, 6:37 PM