Page MenuHomePhabricator
Paste P4433

PHPCS errors after enabling Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween
ActivePublic

Authored by pmiazga on Nov 14 2016, 7:31 PM.
FILE: /opt/mediawiki/vagrant/mediawiki/includes/GlobalFunctions.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
241 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
1408 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
2207 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
2973 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
3010 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../mediawiki/vagrant/mediawiki/includes/specials/SpecialImport.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
569 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/includes/Title.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1111 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../mediawiki/vagrant/mediawiki/includes/content/ContentHandler.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
669 | ERROR | [x] Expected 1 space between type hint and argument
| | "$refreshCache"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...mediawiki/vagrant/mediawiki/includes/specialpage/SpecialPage.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
746 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...t/mediawiki/vagrant/mediawiki/includes/context/ContextSource.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
186 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...agrant/mediawiki/includes/libs/rdbms/database/DatabaseSqlite.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
832 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/includes/OutputPage.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
3701 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/includes/Message.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
431 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
480 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
503 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
525 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
547 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
569 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
591 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
613 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
635 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
659 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../mediawiki/vagrant/mediawiki/includes/filerepo/ForeignDBRepo.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
129 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/includes/filerepo/LocalRepo.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
484 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...awiki/vagrant/mediawiki/includes/filerepo/ForeignDBViaLBRepo.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
91 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/includes/filerepo/FileRepo.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1809 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
1820 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/includes/api/ApiBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
338 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...rant/mediawiki/tests/phpunit/includes/libs/ObjectFactoryTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
166 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
169 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...iki/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
19 | ERROR | [x] Expected 1 space between type hint and argument
| | "$currentTime"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
20 | ERROR | [x] Expected 1 space between type hint and argument
| | "$timeCorrection"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
21 | ERROR | [x] Expected 1 space between type hint and argument
| | "$dateFormat"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
22 | ERROR | [x] Expected 1 space between type hint and argument
| | "$expectedOutput"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
23 | ERROR | [x] Expected 1 space between type hint and argument
| | "$desc"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
152 | ERROR | [x] Expected 1 space between type hint and argument
| | "$currentTime"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
153 | ERROR | [x] Expected 1 space between type hint and argument
| | "$timeCorrection"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
154 | ERROR | [x] Expected 1 space between type hint and argument
| | "$dateFormat"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
155 | ERROR | [x] Expected 1 space between type hint and argument
| | "$expectedOutput"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
156 | ERROR | [x] Expected 1 space between type hint and argument
| | "$desc"; 2 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../mediawiki/tests/phpunit/includes/api/query/ApiQueryTestBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
40 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...wiki/vagrant/mediawiki/maintenance/storage/recompressTracked.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
273 | ERROR | [x] Expected 0 spaces between brackets of function
| | declaration; 1 found
| | (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBetween)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /opt/mediawiki/vagrant/mediawiki/LocalSettings.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
5 | WARNING | [ ] Unnecessary empty comment found
| | (MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment)
9 | WARNING | [ ] Unnecessary empty comment found
| | (MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment)
77 | WARNING | [x] Single space expected between "#" and comment
| | (MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment)
78 | WARNING | [x] Single space expected between "#" and comment
| | (MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment)
96 | WARNING | [x] Single space expected between "#" and comment
| | (MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 3 mins, 39.82 secs; Memory: 152.01Mb