Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Paste
P79272
(An Untitled Masterwork)
Active
Public
Actions
Authored by
•
Scott_French
on Jul 16 2025, 11:35 PM.
Edit Paste
Archive Paste
View Raw File
Subscribe
Mute Notifications
Project Tags
None
Referenced Files
F64896290: raw-paste-data.txt
Jul 16 2025, 11:35 PM
2025-07-16 23:35:26 (UTC+0)
Subscribers
None
Skip superfluous zend internal function frames in the callstack on entry to
tracer_observer_begin / tracer_observer_end.
A similar fix was employed in https://github.com/longxinH/xhprof/issues/68.
--- a/tideways_xhprof.c
+++ b/tideways_xhprof.c
@@ -28,6 +28,10 @@
#include "zend_observer.h"
static void tracer_observer_begin(zend_execute_data *ex) {
+#if PHP_VERSION_ID >= 80200
+ if (ex->func->type == ZEND_INTERNAL_FUNCTION) return;
+#endif
+
if (!TXRG(enabled)) {
return;
}
@@ -36,6 +40,10 @@
}
static void tracer_observer_end(zend_execute_data *ex, zval *return_value) {
+#if PHP_VERSION_ID >= 80200
+ if (ex->func->type == ZEND_INTERNAL_FUNCTION) return;
+#endif
+
if (!TXRG(enabled)) {
return;
}
Event Timeline
•
Scott_French
created this paste.
Jul 16 2025, 11:35 PM
2025-07-16 23:35:26 (UTC+0)
•
Scott_French
mentioned this in
T398245: Prepare WMF PHP 8.3 packages for bullseye
.
Jul 16 2025, 11:43 PM
2025-07-16 23:43:11 (UTC+0)
Jdforrester-WMF
awarded a token.
Jul 17 2025, 1:07 PM
2025-07-17 13:07:36 (UTC+0)
Log In to Comment