Page MenuHomePhabricator
Paste P8017

Important and short patches in AbuseFilter currently under review
ActivePublic

Authored by Daimona on Jan 22 2019, 11:39 AM.
IMPORTANT (sorted by priority)
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/486279/ AND https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/486469/ - Remove profiling globals - important since they blcok several patches, and easy to review
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481524/ AND related changes, up to "Add tests for global filters" - Only unit tests, provide safety and coverage for many other patches.
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/482408/ - "Temporarily exclude Jobs from TitleMove hook" - important, and quite easy to review
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/467774/ - "Overhaul the interface for hiding AbuseLog entries" - pretty important
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/445986/ - "Overhaul Blockautopromote action" - not that urgent
EASY TO REVIEW (no specific order)
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/455871/ - "Add tests for retrieving RC variables" - Unit tests only
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/473456/ - "Add new complete unit tests for most variables" - Unit tests only
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/472458/ - "Add doc for every class member" - Not small, but doc-only
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481635/ - "Fix the regex for numbers, start deprecation of non-decimal numbers"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/478407/ - "Remove usage of MakeGlobalVariablesScript hook"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/468364/ - "Replace deprecated cache-related functions"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/482415/ - "Remove the hacky 'context' variable"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/482418/ - "Remove log_ids meta-variables"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481836/ - "Use lowercase for built-in variables"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481548/ - "Simplify AbuseFilterVariableHolder::dumpAllVars"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/481492/ - "Make AbuseFilterVariableHolder::mVars private"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/454557/ - "Restore (temporarily?) unit tests for CachingParser and fix it"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/478489/ - "Simplify static properties in AbuseFilterHooks"
*https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/468706/ - "Use string cast for Postgres compatibility"

Event Timeline

Daimona edited the content of this paste. (Show Details)Jan 23 2019, 5:07 PM
Daimona edited the content of this paste. (Show Details)Thu, Jan 24, 9:38 AM
Daimona edited the content of this paste. (Show Details)Thu, Jan 31, 9:58 PM
Daimona edited the content of this paste. (Show Details)Fri, Feb 8, 1:14 PM
Daimona edited the content of this paste. (Show Details)Fri, Feb 8, 4:09 PM