Page MenuHomePhabricator
Paste P96513

scap logs (2026-09-23 warning)
ActivePublic
Actions

Authored by Urbanecm_WMF on Wed, Sep 23, 3:07 PM.
Project Tags
None
Referenced Files
F104448539: scap logs (2026-09-23 warning)
Wed, Sep 23, 3:07 PM
Subscribers
None
14:22:36 Checking whether requested changes are valid for backport...
14:22:38 Root change '1344292' processed with 0 relevant dependencies
14:22:38 Root change '1344293' processed with 0 relevant dependencies
14:22:38 Voting on 2 change(s)
14:22:38 Change 1344292 was already merged
14:22:38 Change 1344293 was already merged
14:22:38 Waiting for changes to be merged. This may take some time if there are long running tests.
14:22:38 awaiting-backport-merges: 100% (ok: 2; fail: 0; left: 0)
14:22:38 All changes have been merged
14:22:38 Collecting commits to deploy...
14:22:38 Fetching new changes...
remote: Counting objects: 30142, done
remote: Finding sources: 100% (18/18)
remote: Getting sizes: 100% (8/8)
remote: Compressing objects: 100% (25408/25408)
remote: Total 18 (delta 7), reused 6 (delta 5)
Unpacking objects: 100% (18/18), 20.29 KiB | 2.54 MiB/s, done.
From https://gerrit.wikimedia.org/r/mediawiki/core
56a162f2cda..d6dbd3dac1f wmf/1.47.0-wmf.20 -> origin/wmf/1.47.0-wmf.20
69a404d362e..cabd0cbcf75 fundraising/REL1_39 -> origin/fundraising/REL1_39
03392f76d26..375adf37e9b fundraising/REL1_43 -> origin/fundraising/REL1_43
b7933a87989..fe367b315a1 master -> origin/master
a0331c7c9c5..66b5b640ad5 wmf/1.47.0-wmf.21 -> origin/wmf/1.47.0-wmf.21
Fetching submodule extensions/DonationInterface
From https://gerrit.wikimedia.org/r/mediawiki/extensions/DonationInterface
f8aaedb0a..0bf6d4ca2 deployment -> origin/deployment
Fetching submodule extensions/GrowthExperiments
From https://gerrit.wikimedia.org/r/mediawiki/extensions/GrowthExperiments
1f370102f..b6451d53b master -> origin/master
dac89db22..0bf9fec5f wmf/1.47.0-wmf.20 -> origin/wmf/1.47.0-wmf.20
f9ccb9928..75381e2e7 wmf/1.47.0-wmf.21 -> origin/wmf/1.47.0-wmf.21
remote: Counting objects: 30142, done
remote: Finding sources: 100% (18/18)
remote: Getting sizes: 100% (8/8)
remote: Compressing objects: 100% (25408/25408)
remote: Total 18 (delta 7), reused 6 (delta 5)
Unpacking objects: 100% (18/18), 20.29 KiB | 2.25 MiB/s, done.
From https://gerrit.wikimedia.org/r/mediawiki/core
a0331c7c9c5..66b5b640ad5 wmf/1.47.0-wmf.21 -> origin/wmf/1.47.0-wmf.21
69a404d362e..cabd0cbcf75 fundraising/REL1_39 -> origin/fundraising/REL1_39
03392f76d26..375adf37e9b fundraising/REL1_43 -> origin/fundraising/REL1_43
b7933a87989..fe367b315a1 master -> origin/master
56a162f2cda..d6dbd3dac1f wmf/1.47.0-wmf.20 -> origin/wmf/1.47.0-wmf.20
Fetching submodule extensions/DonationInterface
From https://gerrit.wikimedia.org/r/mediawiki/extensions/DonationInterface
f8aaedb0a..0bf6d4ca2 deployment -> origin/deployment
Fetching submodule extensions/GrowthExperiments
From https://gerrit.wikimedia.org/r/mediawiki/extensions/GrowthExperiments
1f370102f..b6451d53b master -> origin/master
dac89db22..0bf9fec5f wmf/1.47.0-wmf.20 -> origin/wmf/1.47.0-wmf.20
f9ccb9928..75381e2e7 wmf/1.47.0-wmf.21 -> origin/wmf/1.47.0-wmf.21
14:22:44 Collecting commit for I4e6241b9ea4db475d64baa4dd25406af74624d87... 14:22:45 Collecting merge commit for I4e6241b9ea4db475d64baa4dd25406af74624d87 if it exists...
14:22:45 Collecting commit for I4e6241b9ea4db475d64baa4dd25406af74624d87...
14:22:46 Collecting merge commit for I4e6241b9ea4db475d64baa4dd25406af74624d87 if it exists...
14:22:46 No merge commit found.
14:22:47 Started scap prep auto
14:22:47 Update https://gerrit.wikimedia.org/r/operations/mediawiki-config (master branch) in /srv/mediawiki-staging
14:22:47 https://gerrit.wikimedia.org/r/operations/mediawiki-config checked out at commit 27936a056bb5d0d0f06d1beb5a1ebe37e711a830
14:22:47 Update https://gitlab.wikimedia.org/repos/product-safety-and-integrity/hcaptcha-secure-api-vendor.git (deploy branch) in /srv/mediawiki-staging/static/hcaptcha
14:22:48 https://gitlab.wikimedia.org/repos/product-safety-and-integrity/hcaptcha-secure-api-vendor.git checked out at commit 02eec47fe460ee792fbc4f82c6906488202eead3
14:22:48 Update https://gerrit.wikimedia.org/r/mediawiki/core (wmf/1.47.0-wmf.20 branch) in /srv/mediawiki-staging/php-1.47.0-wmf.20
14:22:48 Changes pulled down since last fetch:
commit d6dbd3dac1fd5838e9d759bee8ce8b965461d3a4
Author: Martin Urbanec <martin.urbanec@wikimedia.cz>
Date: Wed Sep 23 16:21:50 2026 +0200
Update git submodules
* Update extensions/GrowthExperiments from branch 'wmf/1.47.0-wmf.20'
to 0bf9fec5fd93353186c4267b7caa497d1676f812
- feat(AddLink): Do not resuggest an already reviewed page
Add Link generates many recommendations for one article, but shows only
the N best ones. When an article returns to the pool, the next newcomer
sees the next-best recommendations, and the quality goes down with each
round. The model also learns from its own edits, because it looks at
words that are links.
Exclude an article from the pool if the article has an accepted or a
rejected row in growthexperiments_link_submissions. One such row means
that a newcomer reviewed the article before.
The table also holds skipped links. A skip is not a decision, so the
query ignores the feedback value 's'. Today the user interface cannot
save a review that skips all links, because
StructuredTaskArticleTarget.isSaveable() needs one accepted or one
rejected link. Each submission thus has at least one accepted or
rejected row. The filter is a safeguard for data from other sources.
This replaces the old check. The old check excluded an article only if
the last edit was an Add Link edit or a revert of one. A later edit from
another user made the article a candidate again. The revert part is also
not necessary anymore, because every article with an Add Link revert
also has an Add Link submission.
The task suggests a change in
LinkRecommendationStore::getExcludedLinkIds. This patch changes
LinkRecommendationUpdater::evaluateTitle instead. getExcludedLinkIds
prunes single link targets inside one recommendation, but the task asks
to exclude the whole article. evaluateTitle is the only place that
decides if an article enters the pool.
The new check runs before the category check and the template check. It
is a cheap lookup on the first two columns of the
gels_page_feedback_target index, and the result never changes. It also
replaces a change_tag query, so the number of queries stays the same.
Two follow-ups are necessary. A revalidation run must remove the
articles that are already in the pool. The dashboard must use the new
outcome label has_prior_submission, because the labels
last_edit_link_recommendation and last_edit_link_recommendation_revert
are gone.
Claude wrote the PHPUnit test in this commit. Claude also reviewed the
production code.
Assisted-by: Claude Opus 5
Bug: T429417
Change-Id: I4e6241b9ea4db475d64baa4dd25406af74624d87
(cherry picked from commit 79ee7b403668ac10c80694de367c5fc3a29b0000)
14:22:48 https://gerrit.wikimedia.org/r/mediawiki/core checked out at commit d6dbd3dac1fd5838e9d759bee8ce8b965461d3a4
[security patches application]
14:22:55 MediaWiki wmf/1.47.0-wmf.20 successfully checked out.
14:22:55 Update https://gerrit.wikimedia.org/r/mediawiki/core (wmf/1.47.0-wmf.21 branch) in /srv/mediawiki-staging/php-1.47.0-wmf.21
14:22:56 Changes pulled down since last fetch:
commit 66b5b640ad5d1bdec6e2754041c7a70b1f62f9bb
Author: Martin Urbanec <martin.urbanec@wikimedia.cz>
Date: Wed Sep 23 16:21:47 2026 +0200
Update git submodules
* Update extensions/GrowthExperiments from branch 'wmf/1.47.0-wmf.21'
to 75381e2e7f48cb024fbfd7e05f7cf3f946b78d2b
- feat(AddLink): Do not resuggest an already reviewed page
Add Link generates many recommendations for one article, but shows only
the N best ones. When an article returns to the pool, the next newcomer
sees the next-best recommendations, and the quality goes down with each
round. The model also learns from its own edits, because it looks at
words that are links.
Exclude an article from the pool if the article has an accepted or a
rejected row in growthexperiments_link_submissions. One such row means
that a newcomer reviewed the article before.
The table also holds skipped links. A skip is not a decision, so the
query ignores the feedback value 's'. Today the user interface cannot
save a review that skips all links, because
StructuredTaskArticleTarget.isSaveable() needs one accepted or one
rejected link. Each submission thus has at least one accepted or
rejected row. The filter is a safeguard for data from other sources.
This replaces the old check. The old check excluded an article only if
the last edit was an Add Link edit or a revert of one. A later edit from
another user made the article a candidate again. The revert part is also
not necessary anymore, because every article with an Add Link revert
also has an Add Link submission.
The task suggests a change in
LinkRecommendationStore::getExcludedLinkIds. This patch changes
LinkRecommendationUpdater::evaluateTitle instead. getExcludedLinkIds
prunes single link targets inside one recommendation, but the task asks
to exclude the whole article. evaluateTitle is the only place that
decides if an article enters the pool.
The new check runs before the category check and the template check. It
is a cheap lookup on the first two columns of the
gels_page_feedback_target index, and the result never changes. It also
replaces a change_tag query, so the number of queries stays the same.
Two follow-ups are necessary. A revalidation run must remove the
articles that are already in the pool. The dashboard must use the new
outcome label has_prior_submission, because the labels
last_edit_link_recommendation and last_edit_link_recommendation_revert
are gone.
Claude wrote the PHPUnit test in this commit. Claude also reviewed the
production code.
Assisted-by: Claude Opus 5
Bug: T429417
Change-Id: I4e6241b9ea4db475d64baa4dd25406af74624d87
(cherry picked from commit 79ee7b403668ac10c80694de367c5fc3a29b0000)
14:22:56 https://gerrit.wikimedia.org/r/mediawiki/core checked out at commit 66b5b640ad5d1bdec6e2754041c7a70b1f62f9bb
[security patches]
14:23:03 MediaWiki wmf/1.47.0-wmf.21 successfully checked out. [13/349]
14:23:03 Finished scap prep auto (duration: 00m 15s)
___ ____
⎛ ⎛ ,----
\ //==--'
_//|,.·//==--' ____________________________
_OO≣=- ︶ ᴹw ⎞_§ ______ ___\ ___\ ,\__ \/ __ \
(∞)_, ) ( | ______/__ \/ /__ / /_/ / /_/ /
¨--¨|| |- ( / ______\____/ \___/ \__^_/ .__/
««_/ «_/ jgs/bd808 /_/
14:23:04 Running sudo -u mwbuilder /usr/local/bin/update-mediawiki-tools-release
Already up to date.
14:23:04 Started scap sync-world: Backport for [[gerrit:1344292|feat(AddLink): Do not resuggest an already reviewed page (T429417)]], [[gerrit:1344293|feat(AddLink): Do not resuggest an already reviewed page (T429417)]]
14:23:05 Started cache_git_info
14:23:06 Finished cache_git_info (duration: 00m 00s)
14:23:06 Started l10n-update
14:23:07 Updating ExtensionMessages-1.47.0-wmf.20.php
14:23:12 Updating LocalisationCache for 1.47.0-wmf.20 using 22 thread(s)
14:23:12 Running rebuildLocalisationCache.php (cdb)
14:23:15 0 languages rebuilt out of 549
14:23:15 Use --force to rebuild the caches which are still fresh.
14:23:16 Generating JSON versions and md5 files (as www-data)
14:23:21 Updating ExtensionMessages-1.47.0-wmf.21.php
14:23:26 Updating LocalisationCache for 1.47.0-wmf.21 using 22 thread(s)
14:23:26 Running rebuildLocalisationCache.php (cdb)
14:23:29 0 languages rebuilt out of 549
14:23:29 Use --force to rebuild the caches which are still fresh.
14:23:30 Generating JSON versions and md5 files (as www-data)
14:23:33 Finished l10n-update (duration: 00m 26s)
14:23:33 Checking for new runtime errors locally
14:23:36 Started build-and-push-container-images
14:23:36 K8s images build/push output redirected to /home/urbanecm/scap-image-build-and-push-log
14:24:38 Finished build-and-push-container-images (duration: 01m 02s)
14:24:39 Started sync-masters
14:24:40 ['/usr/bin/scap', 'pull-master', 'deploy1003.eqiad.wmnet'] (ran as mwdeploy@deploy2002.codfw.wmnet) returned [1]: Traceback (most recent call last):
File "/usr/bin/scap", line 3, in <module>
from scap import cli
ImportError: cannot import name 'cli' from 'scap' (unknown location)
14:24:57 sync-masters: 100% (in-flight: 0; ok: 1; fail: 1; left: 0)
14:24:57 1 masters had sync errors
14:24:57 Finished sync-masters (duration: 00m 17s)
14:24:57 Started Collecting rollback information
14:24:59 Finished Collecting rollback information (duration: 00m 02s)
14:24:59 Started sync-testservers-k8s
14:29:24 K8s deployment progress: 100% (ok: 16; fail: 0; left: 0)
14:29:24 Finished sync-testservers-k8s (duration: 04m 25s)
14:29:24 Started testserver-check-commands
14:29:24 Executing check 'httpbb /srv/deployment/httpbb-tests/appserver/* --hosts=mwdebug.discovery.wmnet --https_port=4444 --retry_on_timeout'
14:29:24 Executing check 'httpbb /srv/deployment/httpbb-tests/appserver/* --hosts=mwdebug-next.discovery.wmnet --https_port=4453 --retry_on_timeout'
14:29:24 Executing check 'httpbb /srv/deployment/httpbb-tests/pretrain/* --hosts=mw-pretrain.discovery.wmnet --https_port=30443 --request_header 'x-wikimedia-debug: backend=k8s-mw-pretrain' --retry_on_timeout'
14:29:57 Finished testserver-check-commands (duration: 00m 32s)
14:29:57 Started sync-canaries-k8s
14:32:47 K8s deployment progress: 100% (ok: 64; fail: 0; left: 0)
14:32:47 Finished sync-canaries-k8s (duration: 02m 49s)
14:32:47 Waiting 20 seconds for canary traffic...
14:33:07 Logstash checker counted 0 error(s) in the last 20 seconds. OK.
14:33:07 Logstash checker counted 0 error(s) in the last 20 seconds. OK.
14:33:07 Started sync-prod-k8s
14:37:09 K8s deployment progress: 97% (ok: 2715; fail: 0; left: 75)
14:37:09 K8s deployment continues in the background.
14:37:09 Finished sync-prod-k8s (duration: 04m 02s)
14:37:09 Started production-check-commands
14:37:09 Executing check 'httpbb /srv/deployment/httpbb-tests/pretrain/* --hosts=mw-pretrain.discovery.wmnet --https_port=30443 --retry_on_timeout'
14:37:17 Finished production-check-commands (duration: 00m 07s)
14:37:17 Waiting 20 seconds for production traffic...
14:37:37 Logstash checker counted 8 error(s) in the last 20 seconds. OK.
14:37:37 Logstash checker counted 8 error(s) in the last 20 seconds. OK.
14:37:37 Running purgeMessageBlobStore.php
14:37:38 Finished scap sync-world: Backport for [[gerrit:1344292|feat(AddLink): Do not resuggest an already reviewed page (T429417)]], [[gerrit:1344293|feat(AddLink): Do not resuggest an already reviewed page (T429417)]] (duration: 14m 34s)
14:37:39 backport failed: <CalledProcessError> Command '['/usr/bin/scap', 'sync-world', '--backport', 'Backport for [[gerrit:1344292|feat(AddLink): Do not resuggest an already reviewed page (T429417)]], [[gerrit:1344293|feat(AddLink): Do not resuggest an already reviewed page (T429417)]]']' returned non-zero exit status 1. (scap version: 4.291.0) (duration: 15m 03s)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits