HomePhabricator

Update patch set 2
3c15e01de629Unpublished

Authored by thiemowmde on Oct 11 2017, 5:58 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 2

Patch Set 2:

Hm, what can we do here? Who does have knowledge about what's going on in this patch? I, personally, don't even understand what "tweak" and "more idiomatic" in the commit message refers to. It also talks about "consumers". Which consumers would that be? What drives this change? Is this still the same project that motivated the original JSON-LD support? (Which was introduced just recently, if I remember correctly.)

I would love to add this to the proper column on a proper board, but T44063 is an epic that doesn't belong to a review column, and T164655 appears to be unrelated. Or the relation is very much unclear. What code is going to consume this specific export format? Maybe explaining that would help?

Does anybody of the people working on the specific project this is needed for have merge rights here in the Wikibase code base? If your project is the only consumer of this format, I don't mind if somebody else merges this (it should just not be the uploader doing a self-merge).

Patch-set: 2

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Oct 11 2017, 5:58 PM
Parents
R1907:106b4f729c98: Update patch set 2
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed R1907:3c15e01de629: Update patch set 2 (authored by thiemowmde).Oct 11 2017, 5:58 PM

Empty Commit

This commit is empty and does not affect any paths.