HomePhabricator

Skip simple strings in N3Quoter::escapeLiteral
da04a05d53edUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Skip simple strings in N3Quoter::escapeLiteral

This makes the function about 50% faster on the first 5,000 Wikidata
entities. That makes the truthy dump about 7% faster in general.

This might have more or less effect on the entire truthy dump, but
I'm not willing to benchmark this in detail.

I've also added some more tests here that pass with both the old
and the new version.

Bug: T176844
Change-Id: I7141a58a022a98373c1390ee4e336fb9ee54f6c2

Details

Provenance
hooAuthored on Sep 28 2017, 2:45 PM
Parents
R1907:58f500e378c0: Minor code structure clean ups in JsonLdRdfWriter
Branches
Unknown
Tags
Unknown
ChangeId
I7141a58a022a98373c1390ee4e336fb9ee54f6c2