BlogPage::getCommentsOfTheDay
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	lcawte
	May 22 2015, 3:58 PM

Description

The code in changeset 211966 is only one piece of the puzzle. The code is mostly duplicated in BlogPage as getCommentsOfTheDay(). This also needs to be updated. See T98550.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/BlogPage	master	+3 -95	Use Ext:Comments for comments of the day
mediawiki/extensions/BlogPage	master	+17 -51	Finally make the "comments of the day" feature work again
mediawiki/extensions/Comments	master	+99 -86	Comments of the day cleaned up & unconditionally enabled
mediawiki/extensions/Comments	master	+105 -97	[WIP/UNTESTED?] Version 4.2.0: comments of the day cleaned up & unconditionally enabled

Customize query in gerrit

Related Objects

Mentioned In: T155511: LinkPage::getCommentsOfTheDay() should use CommentsOfTheDay::get() instead of duplicating the logic in a broken manner
T100025: Reduce Social Tools code duplication
Mentioned Here: T98550: Comment_Plus_Count and Comments_Minus_Count columns missing

Event Timeline

lcawte created this task.May 22 2015, 3:58 PM

lcawte raised the priority of this task from to Unbreak Now!.

lcawte updated the task description. (Show Details)

lcawte added a project: BlogPage.

lcawte added a subscriber: lcawte.

Restricted Application added a project: Social-Tools. · View Herald TranscriptMay 22 2015, 3:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

lcawte mentioned this in T100025: Reduce Social Tools code duplication.May 22 2015, 4:00 PM

lcawte added a subscriber: UltrasonicNXT.May 22 2015, 4:07 PM

UltrasonicNXT claimed this task.May 23 2015, 10:09 AM

Change 214938 had a related patch set uploaded (by UltrasonicNXT):
Use Ext:Comments for comments of the day

https://gerrit.wikimedia.org/r/214938

gerritbot added a project: Patch-For-Review.May 31 2015, 7:57 PM

@UltrasonicNXT, @lcawte:

This task has been "Unbreak now!" priority for more than two weeks.
A patch is available but has not been reviewed yet.

The definition of "Unbreak now" is "to be fixed immediately".

Please either review/merge the patch or correct the priority value of this task. Thank you!

In T100024#1364833, @Aklapper wrote:

@UltrasonicNXT, @lcawte:

This task has been "Unbreak now!" priority for more than two weeks.
A patch is available but has not been reviewed yet.

The definition of "Unbreak now" is "to be fixed immediately".

Please either review/merge the patch or correct the priority value of this task. Thank you!

@Aklapper - It has been reviewed. I'll quote the patch author's most recent comment - "Right, that's some of the comments fixed, but still work to do."

It is 'Unbreak now' because until that change is merged, the extension's main functionality is broken because the database schema has changed.

lcawte added a subscriber: ashley.Jun 15 2015, 12:56 PM

In T100024#1365408, @lcawte wrote:

It is 'Unbreak now' because until that change is merged, the extension's main functionality is broken

Who plans to work on https://gerrit.wikimedia.org/r/#/c/214938/ ?

In T100024#1365408, @lcawte wrote:

It is 'Unbreak now' because until that change is merged, the extension's main functionality is broken

Who plans to work on https://gerrit.wikimedia.org/r/#/c/214938/ ?

I'm on it

In T100024#1611708, @UltrasonicNXT wrote:

I'm on it

@@UltrasonicNXT: Any news?

(Removing "Unbreak now" priority as this was set for more than half a year ago but reality has shown that this task has not such a level of urgency.)

Change 275197 had a related patch set uploaded (by Jack Phoenix):
[WIP/UNTESTED?] Version 4.2.0: comments of the day cleaned up & unconditionally enabled

https://gerrit.wikimedia.org/r/275197

Change 275197 abandoned by Jack Phoenix:
[WIP/UNTESTED?] Version 4.2.0: comments of the day cleaned up & unconditionally enabled

Reason:
Will submit again as a new changeset.

https://gerrit.wikimedia.org/r/275197

Change 275198 had a related patch set uploaded (by Jack Phoenix):
[WIP/UNTESTED?] Version 4.2.0: comments of the day cleaned up & unconditionally enabled

https://gerrit.wikimedia.org/r/275198

SamanthaNguyen moved this task from Backlog to BlogPage on the Social-Tools board.May 8 2016, 3:04 PM

SamanthaNguyen moved this task from Backlog to Feedback / Suggestions on the BlogPage board.May 8 2016, 4:04 PM

SamanthaNguyen moved this task from Feedback / Suggestions to Feedback on the BlogPage board.Sep 19 2016, 4:36 AM

Change 275198 merged by Jack Phoenix:
Comments of the day cleaned up & unconditionally enabled

https://gerrit.wikimedia.org/r/275198

Change 331082 had a related patch set uploaded (by Jack Phoenix):
Finally make the "comments of the day" feature work again

https://gerrit.wikimedia.org/r/331082

I reckon this can be closed now if people agree?

It looks like the 2nd patch hasn't been merged yet, which is changset 331082.

Change 331082 merged by jenkins-bot:
Finally make the "comments of the day" feature work again

https://gerrit.wikimedia.org/r/331082