Page MenuHomePhabricator
Create Task
Maniphest T100111

Update user-agent in compat to include username
Closed, ResolvedPublic
Actions

Description

Core sends a really nice user-agent string which includes the username. We should update compat to send the same information. This makes it easier to find users who are still running compat instead of core.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add username and sitename to the user-agentpywikibot/compatmaster+6 -4
Customize query in gerrit

Related Objects

Event Timeline

Multichill created this task.May 23 2015, 9:06 PM
Multichill raised the priority of this task from to High.
Multichill updated the task description. (Show Details)
Multichill added a project: Pywikibot-compat-to-core.
Multichill added subscribers: Multichill, valhallasw, Ladsgroup, jayvdb.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2015, 9:06 PM
valhallasw mentioned this in T99365: [RFC] Compat deprecation.May 23 2015, 9:07 PM
Multichill added a comment.May 23 2015, 9:33 PM

Current code in compat: https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/8a2e75e99db55ec8d5d275b6c48ae5470b501d27/wikipedia.py#L6060

Current code in core: https://git.wikimedia.org/blob/pywikibot%2Fcore.git/7f50b4ed6bdf27e7e29e6de0c3cf7999d267337e/pywikibot%2Fcomms%2Fhttp.py#L134

Ricordisamoa subscribed.May 24 2015, 12:17 AM
gerritbot subscribed.May 24 2015, 9:43 AM

Change 213217 had a related patch set uploaded (by Ladsgroup):
Add username and sitename to the user-agent

https://gerrit.wikimedia.org/r/213217

gerritbot added a project: Patch-For-Review.May 24 2015, 9:43 AM
gerritbot added a comment.May 24 2015, 2:29 PM

Change 213217 merged by jenkins-bot:
Add username and sitename to the user-agent

https://gerrit.wikimedia.org/r/213217

Ladsgroup mentioned this in rPWBOb292c1a8d98d: Add username and sitename to the user-agent.May 24 2015, 2:29 PM
Ladsgroup closed this task as Resolved.May 24 2015, 2:42 PM
Ladsgroup edited projects, added Wikimedia-Hackathon-2015; removed Patch-For-Review.
Ladsgroup set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits