fail on Windows host
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mobrovac
	May 24 2015, 4:08 PM

Description

T89919: Services in Vagrant should not be cloned into root moved Node.JS service repos into /vagrant/srv, which causes node module installs to fail on Windows hosts. The root cause are symlinks created by npm for certain modules.

Options:

Symlinks become available when Vagrant is run with admin rights, so list that as a workaround on the MW-Vagrant page.
Use npm install --no-bin-links and then try to work around various issues that might arise for each service.
Move them out of /vagrant and bikeshed yet again on where to actually put them

I'm strongly in favour of option 1 as it affects only Windows users that install services.

First reported in T90353 , recently appeared in https://gerrit.wikimedia.org/r/#/c/211957/2/puppet/modules/mathoid/manifests/install/git.pp

Details

	Subject	Repo	Branch	Lines +/-
	Introduce the service class and service::node define	mediawiki/vagrant	master	+300 -114

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• GWicke	T88585 Create a standard service template / init / logging / package setup
Duplicate	None	T95399 Update Graphoid Puppet role/module in MW-Vagrant
Resolved	KartikMistry	T88163 Create MediaWiki-Vagrant module and role for Content Translation
Resolved	• mobrovac	T90315 Create a vagrant puppet role for service-runner based services
Resolved	• mobrovac	T90353 Unable to run npm start on Vagrant under windows in shared dir
Resolved	• mobrovac	T100202 Cloning Node.JS service repos into /vagrant/srv/ fail on Windows host

Event Timeline

• mobrovac created this task.May 24 2015, 4:08 PM

• mobrovac raised the priority of this task from to High.

• mobrovac updated the task description. (Show Details)

• mobrovac added a project: MediaWiki-Vagrant.

• mobrovac added subscribers: • mobrovac, • dduvall, bd808, Physikerwelt.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2015, 4:08 PM

• mobrovac added a parent task: T90353: Unable to run npm start on Vagrant under windows in shared dir.May 24 2015, 4:09 PM

Windows hosts don't use NFS. Have you verified that this is really the problem? It seems more likely that the native Windows filesystem does not support symlinks.

• mobrovac added a parent task: T90315: Create a vagrant puppet role for service-runner based services.May 24 2015, 4:10 PM

In T100202#1307631, @bd808 wrote:

Windows hosts don't use NFS. Have you verified that this is really the problem? It seems more likely that the native Windows filesystem does not support symlinks.

Duh, you are right. No NFS, only no support for symlinks.

Changed the task desc and gave some options there. Thoughts?

Maybe tell npm not to use symlinks (sounds easy) or trick VirtualBox into actually supporting symlinks (sounds possibly hard)?

I think simply not using npm symlinks is the easiest way to go about this, as it's least discomforting for users. That will render npm start, npm test and the likes unusable in these repos, but there will still be ways to get the equivalent behaviour if needed. I'll amend change Ia38d8727 accordingly.

• mobrovac claimed this task.Jun 5 2015, 4:52 PM

Change 214919 had a related patch set uploaded (by Mobrovac):
Introduce the service class and service::node define

https://gerrit.wikimedia.org/r/214919

gerritbot added a project: Patch-For-Review.Jun 5 2015, 5:45 PM

• mobrovac moved this task from Backlog to Awaiting review on the MediaWiki-Vagrant board.Jun 15 2015, 12:45 PM

Physikerwelt awarded a token.Jun 15 2015, 1:22 PM

Change 214919 merged by jenkins-bot:
Introduce the service class and service::node define

https://gerrit.wikimedia.org/r/214919

• mobrovac mentioned this in rMWVA59c0da55f664: Introduce the service class and service::node define.Jun 22 2015, 10:09 PM

• mobrovac moved this task from Awaiting review to Done on the MediaWiki-Vagrant board.Jun 22 2015, 11:45 PM

• mobrovac closed this task as Resolved.Jun 22 2015, 11:47 PM

• mobrovac removed a project: Patch-For-Review.