Page MenuHomePhabricator

Do not show RC patrol UI to reviewers on reviewable revisions
Open, LowPublic


When RC patrol is used concomitantly with FlaggedRevs (e.g. in its protection version), both the review interface and RC patrol interface appear on reviewable diffs. See background.
Since reviewing has for effect to mark the reviewed revisions patrolled, I think we should not show the RC patrol UI since it is still present after the review even though they have been patrolled already (users might think they weren't patrolled, and do it for nothing).

In core, we could ask extensions with the DiffViewHeader hook.

Event Timeline

Cenarium claimed this task.
Cenarium raised the priority of this task from to Low.
Cenarium updated the task description. (Show Details)
Cenarium added a subscriber: Cenarium.

Change 213578 had a related patch set uploaded (by Cenarium):
Allow extensions to not show RC patrol UI in diff

Change 213582 had a related patch set uploaded (by Cenarium):
Don't show RC patrol UI on reviewable diffs

Change 213578 abandoned by Cenarium:
Allow extensions to not show RC patrol UI in diff

Used js instead

Since having also the patrol link may be desirable in some cases, I've instead removed the patrol link with JS when the revision gets reviewed.

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See for tips how to best manage your individual work in Phabricator.)