Maniphest T100348

Edit icon misaligned in stable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 25 2015, 7:10 PM

Tags

Referenced Files

	F177854: Screen Shot 2015-06-11 at 11.11.40.png
	Jun 11 2015, 10:12 AM

Subscribers

Description

Screenshot to follow when I'm not on mobile.
Edit icon on h2s is aligned top rather than centred.

Also shows on all sections rather than top level.

Details

	Subject	Repo	Branch	Lines +/-
	Vertically align the floated edit icon inside H2	mediawiki/extensions/MobileFrontend	master	+2 -0
	Correctly align the heading edit icon	mediawiki/extensions/MobileFrontend	master	+3 -24

Customize query in gerrit

Related Objects

Mentioned In: rEMFR1836ab963473: Vertically align the floated edit icon inside H2
rMEXTdff5735f894b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR192856fd4558: Correctly align the heading edit icon
rMEXTe2a285e96a76: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
Mentioned Here: T87644: Show edit section icons for all sections, not just h2

Event Timeline

Jdlrobson created this task.May 25 2015, 7:10 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2015, 7:10 PM

@phuedx css regression we should look into asap?

Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.May 27 2015, 6:31 PM

Jdlrobson added a project: Mobile-Web-Sprint-48-Voyage-of-the-Damned.

Jdlrobson set Security to None.

Also shows on all sections rather than top level.

I think it was requested by WikiData (or some other project). Maybe @Florian knows?

In T100348#1316254, @bmansurov wrote:

Also shows on all sections rather than top level.

I think it was requested by WikiData (or some other project). Maybe @Florian knows?

See T87644: Show edit section icons for all sections, not just h2.

Thanks, @Florian!

Okay but the edit icon is still misaligned and that should be fixed :)

phuedx moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 2 2015, 9:38 AM

• bmansurov claimed this task.Jun 2 2015, 7:53 PM

• bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.

Change 215513 had a related patch set uploaded (by Bmansurov):
Correctly align the heading edit icon

https://gerrit.wikimedia.org/r/215513

gerritbot added a project: Patch-For-Review.Jun 2 2015, 9:19 PM

• bmansurov moved this task from Doing to Code Review on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 2 2015, 9:19 PM

Change 215513 merged by jenkins-bot:
Correctly align the heading edit icon

https://gerrit.wikimedia.org/r/215513

Diffusion mentioned this in rMEXTe2a285e96a76: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 3 2015, 7:52 PM

• bmansurov mentioned this in rEMFR192856fd4558: Correctly align the heading edit icon.Jun 3 2015, 7:53 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 3 2015, 7:53 PM

AFAICT the icon remains misaligned.

Screen Shot 2015-06-11 at 11.11.40.png (95×350 px, 12 KB)

phuedx edited projects, added Mobile-Web-Sprint-49-Wayne's-World; removed Patch-For-Review, Mobile-Web-Sprint-48-Voyage-of-the-Damned.Jun 11 2015, 10:12 AM

phuedx moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.

Jdlrobson moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 11 2015, 4:57 PM

• bmansurov removed • bmansurov as the assignee of this task.Jun 12 2015, 9:19 PM

• bmansurov moved this task from Doing to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.

• bmansurov claimed this task.Jun 15 2015, 11:02 PM

• bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

• bmansurov moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 11:18 PM

Change 218538 had a related patch set uploaded (by Bmansurov):
Vertically align the floated edit icon inside H2

https://gerrit.wikimedia.org/r/218538

gerritbot added a project: Patch-For-Review.Jun 15 2015, 11:18 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 12:33 AM

218538 hasn't been merged yet…

Change 218538 merged by jenkins-bot:
Vertically align the floated edit icon inside H2

https://gerrit.wikimedia.org/r/218538

Diffusion mentioned this in rMEXTdff5735f894b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 16 2015, 5:04 PM

Jdlrobson mentioned this in rEMFR1836ab963473: Vertically align the floated edit icon inside H2.Jun 16 2015, 5:04 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 5:12 PM

https://gerrit.wikimedia.org/r/218538 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 1:31 PM

phuedx removed a project: Patch-For-Review.Jun 19 2015, 7:22 PM

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:25 AM