Page MenuHomePhabricator
Create Task
Maniphest T100348

Edit icon misaligned in stable
Closed, ResolvedPublic
Actions

Description

Screenshot to follow when I'm not on mobile.
Edit icon on h2s is aligned top rather than centred.

Also shows on all sections rather than top level.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+2 -0Vertically align the floated edit icon inside H2
mediawiki/extensions/MobileFrontendmaster+3 -24Correctly align the heading edit icon
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 25 2015, 7:10 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2015, 7:10 PM
Jdlrobson added a subscriber: phuedx.May 26 2015, 10:41 AM

@phuedx css regression we should look into asap?

bmansurov added subscribers: Florian, bmansurov.May 28 2015, 12:12 AM

Also shows on all sections rather than top level.

I think it was requested by WikiData (or some other project). Maybe @Florian knows?

Florian added a comment.May 28 2015, 5:53 AM
In T100348#1316254, @bmansurov wrote:

Also shows on all sections rather than top level.

I think it was requested by WikiData (or some other project). Maybe @Florian knows?

See T87644: Show edit section icons for all sections, not just h2.

Jdlrobson added a comment.May 28 2015, 10:28 PM

Okay but the edit icon is still misaligned and that should be fixed :)

bmansurov claimed this task.Jun 2 2015, 7:53 PM
bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.
gerritbot added a subscriber: gerritbot.Jun 2 2015, 9:19 PM

Change 215513 had a related patch set uploaded (by Bmansurov):
Correctly align the heading edit icon

https://gerrit.wikimedia.org/r/215513

gerritbot added a comment.Jun 3 2015, 7:52 PM

Change 215513 merged by jenkins-bot:
Correctly align the heading edit icon

https://gerrit.wikimedia.org/r/215513

phuedx added a comment.Jun 11 2015, 10:12 AM

AFAICT the icon remains misaligned.

bmansurov removed bmansurov as the assignee of this task.Jun 12 2015, 9:19 PM
bmansurov moved this task from Doing to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.
bmansurov claimed this task.Jun 15 2015, 11:02 PM
bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.
gerritbot added a comment.Jun 15 2015, 11:18 PM

Change 218538 had a related patch set uploaded (by Bmansurov):
Vertically align the floated edit icon inside H2

https://gerrit.wikimedia.org/r/218538

gerritbot added a comment.Jun 16 2015, 5:03 PM

Change 218538 merged by jenkins-bot:
Vertically align the floated edit icon inside H2

https://gerrit.wikimedia.org/r/218538

phuedx closed this task as Resolved.Jun 17 2015, 1:30 PM

Verified on BC.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL