Page MenuHomePhabricator

Show last edited timestamps on Special:EditWatchlist
Closed, ResolvedPublic

Description

Special:EditWatchlist displays last modified timestamps inline, which can often be very different from the last edited timestamp we show at the top of the page (in stable). We should show the last edited timestamp on Special:EditWatchlist for consistency.

AC:

  • Watchlist entries on mobile do not show "modified" and the modified date.
  • Watchlist entries on mobile show "last edited" and the last edit date as we do on the page last edit bar (see screenshot).


Original bug report

The last modified time given under each article on the mobile version of watchlist are often (always) wrong. Not even close. They're not even wrong by the same amount. For example, it will show "modified 2 hours ago" when the actual edit was 10 months earlier.

I've attached an screenshot of my watchlist with a couple article pages. While I've only included the first two articles, every last-modified time given in the watchlist does not match the one given on the page.

Event Timeline

Bp0 created this task.May 25 2015, 8:49 PM
Bp0 raised the priority of this task from to Needs Triage.
Bp0 updated the task description. (Show Details)
Bp0 added a subscriber: Bp0.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2015, 8:49 PM
Krenair added a subscriber: Krenair.
bmansurov claimed this task.Jun 2 2015, 5:19 PM
bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.

I think those pages are showing the correct information. On article pages we show the last edited timestamp [1], and on the watchlist page we show the last modified timestamp [2] as the labels indicate. A quote from the documentation about the last modified timestamp [2]:

Aside from editing this includes permission changes, creation or deletion of linked pages, and alteration of contained templates.

The screenshots also confirm this - the last edited timestamp is earlier than the last modified timestamp in both cases.

If we decide to change this behavior, I'd like to know to what. Pinging Design and @JKatzWMF to see if they have anything to say.

[1] https://www.mediawiki.org/wiki/Manual:Revision_table#rev_timestamp
[2] https://www.mediawiki.org/wiki/Manual:Page_table#page_touched

Bp0 added a comment.EditedJun 2 2015, 9:10 PM

It appears that you are right, as a null edit will change the time on the watchlist but not on the page. What is the value of that?

@kaldari, what do you think about ^?

@KHammerstein: Arguably, this is UX debt. What do you think about this?

@phuedx This looks to me like a bug on an existing feature. I think we should fix it but I'll leave it up to how you guys prioritize bugs.
UX debt would address new features or iterations on existing features, not technical bugs.

@bmansurov Oh I see what you're saying. Lets make them consistent. Should we go with last edited or last modified on both?

KHammerstein removed KHammerstein as the assignee of this task.Jun 20 2015, 12:48 AM

@KHammerstein, I think we should go with 'last edited'. I don't think many people care about the time when a permission changes for example.

@KHammerstein, I think we should go with 'last edited'. I don't think many people care about the time when a permission changes for example.

+1

phuedx renamed this task from Mobile version of Special:EditWatchlist lists incorrect last-modified times to Show last edited timestamps on Special:EditWatchlist.Jun 24 2015, 2:14 PM
phuedx updated the task description. (Show Details)
Florian added a subscriber: Florian.Jul 5 2015, 8:53 PM

Hmm, I think, that a protection of a page should be visible in the Watchlist, too (btw. it's visible in the desktop watchlist). It's an important information for the editing community, just as an edit to a page.

Bp0 added a comment.Jul 6 2015, 6:19 AM

Another kindof absurd example: if one is watching the page [[Chinese calendar]] the last modified time in the mobile watchlist is whenever someone last clicked the "refresh" link in the little box on the left, or the "purge" link in the Structure -> Day, hour, and week section. That doesn't really seem useful in any way.

Let's make it consistent with the date shown in the page, thanks for the input to everyone. Moving to next sprint.

Thanks for the report @Bp0.

Jhernandez triaged this task as Normal priority.Aug 13 2015, 7:23 PM
Jhernandez updated the task description. (Show Details)
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptAug 13 2015, 7:23 PM
kaldari removed a subscriber: kaldari.Aug 13 2015, 7:58 PM
MaxSem removed a subscriber: MaxSem.Aug 18 2015, 5:17 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-54-28-Days-Later board.

Change 234705 had a related patch set uploaded (by Jdlrobson):
Be consistent in generation of last edited times

https://gerrit.wikimedia.org/r/234705

kaldari removed a subscriber: kaldari.Aug 29 2015, 1:26 AM
Jdlrobson moved this task from Backlog to Tech debt on the MobileFrontend board.Sep 2 2015, 7:47 PM

Change 234705 merged by jenkins-bot:
Be consistent in generation of last edited times

https://gerrit.wikimedia.org/r/234705