Fix "style module should define its position explicitly" warnings
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	• Gilles
	May 26 2015, 8:25 AM

Description

Following T97420 migration warnings are being output to track down code that calls addModuleStyles on modules that don't specify their position explicitly.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make ext.echo.badge styles load at bottom of page	mediawiki/extensions/Echo	master	+1 -1
	Explicitly set position on various RL modules	mediawiki/extensions/MobileFrontend	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: rEMFR863e301618ae: Explicitly set position on various RL modules
rMEXT8d8cfe189584: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
Mentioned Here: T97420: Support position "bottom" for addModuleStyles

Event Timeline

• Gilles created this task.May 26 2015, 8:25 AM

• Gilles claimed this task.

• Gilles raised the priority of this task from to Needs Triage.

• Gilles updated the task description. (Show Details)

• Gilles added projects: Performance-Team, MediaWiki-ResourceLoader.

• Gilles subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2015, 8:25 AM

• Gilles triaged this task as Medium priority.May 26 2015, 8:25 AM

Change 213787 had a related patch set uploaded (by Jdlrobson):
Make ext.echo.badge styles load at bottom of page

https://gerrit.wikimedia.org/r/213787

Change 213785 had a related patch set uploaded (by Jdlrobson):
Explicitly set position on various RL modules

https://gerrit.wikimedia.org/r/213785

Change 213785 merged by jenkins-bot:
Explicitly set position on various RL modules

https://gerrit.wikimedia.org/r/213785

Jdlrobson mentioned this in rMEXT8d8cfe189584: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 26 2015, 8:36 AM

Jdlrobson mentioned this in rEMFR863e301618ae: Explicitly set position on various RL modules.

• Gilles closed this task as a duplicate of T97410: Make position of modules currently added with addModuleStyles explicit.May 26 2015, 8:42 AM

Change 213787 abandoned by Jdlrobson:
Make ext.echo.badge styles load at bottom of page

Reason:
i forget why i was doing this now