Page MenuHomePhabricator

syntaxhighlight lang parameter accepts languages that WMF wikis have dropped.
Closed, DeclinedPublic

Description

gerrit:197449 drops syntax highlighting for a bunch of languages on WMF wikis, e.g. lang="lotusscript". Yet there's no warning when you specify a dropped language, you just get a <pre> block with no highlighting. This sandbox revision demonstrates the glitch.

I think the issue is the extension's parserHook() doesn't check $wgGeSHiSupportedLanguages; it prepares a new GeSHi object and this successfully loads the lotusscript.php code despite the wiki not loading CSS to style the highlighting.

This may be moot if T93025: Combine infrequently-used language modules into a single module is addressed and/or the chechil fork of GeSHi unifies CSS. The extension's wiki page mentions this bug.

Event Timeline

Spage raised the priority of this task from to Low.
Spage updated the task description. (Show Details)
Spage added a project: SyntaxHighlight.
Spage added subscribers: Spage, MaxSem, TheDJ.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2015, 9:03 PM
ori closed this task as Declined.Jun 22 2015, 11:34 PM
ori claimed this task.
ori added a subscriber: ori.

Obsoleted by T85794.