Page MenuHomePhabricator
Create Task
Maniphest T100522

-cat argument conflict
Open, MediumPublic
Actions

Description

-cat is handled by pagegens , but is also implemented in checkimages.py and template.py

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
template.py: solve -cat argument conflictpywikibot/coremaster+14 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT76429 argparse support for global & pagegen arguments
 OpenNoneT182523 option conflict (tracking)
 OpenNoneT100522 -cat argument conflict
 OpenNoneT100618 checkimages.py pagegen support

Event Timeline

jayvdb created this task.May 27 2015, 3:41 PM
jayvdb assigned this task to XZise.
jayvdb raised the priority of this task from to Medium.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Patch-For-Review, Pywikibot.
jayvdb added subscribers: jayvdb, Ricordisamoa, Ladsgroup and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2015, 3:41 PM
jayvdb removed XZise as the assignee of this task.May 27 2015, 3:41 PM
jayvdb removed a project: Patch-For-Review.
jayvdb set Security to None.
jayvdb updated the task description. (Show Details)
gerritbot subscribed.May 28 2015, 9:10 PM

Change 214487 had a related patch set uploaded (by Mpaa):
template.py: solve -cat argument conflict

https://gerrit.wikimedia.org/r/214487

gerritbot added a project: Patch-For-Review.May 28 2015, 9:10 PM
gerritbot added a comment.Jun 5 2015, 4:49 PM

Change 214487 merged by jenkins-bot:
template.py: solve -cat argument conflict

https://gerrit.wikimedia.org/r/214487

Mpaa mentioned this in rPWBC4ae83254b25c: template.py: solve -cat argument conflict.Jun 5 2015, 4:50 PM
jayvdb updated the task description. (Show Details)Jun 5 2015, 4:51 PM
jayvdb removed a project: Patch-For-Review.
Ricordisamoa added a comment.Jun 5 2015, 5:17 PM

Unlike template.py, checkimages.py does not use GeneratorFactory, so why does the -cat argument conflict?

jayvdb added a comment.Jun 5 2015, 5:45 PM

See subtask.

Ricordisamoa added a comment.Jun 5 2015, 11:44 PM
In T100522#1341789, @jayvdb wrote:

See subtask.

So it's more a 'jurisdiction' issue than a conflict.

jayvdb added a comment.Jun 5 2015, 11:59 PM

In the case of checkimages, yes. Users will expect an argument works consistently across all scripts, and not have subtle bugs due to differing implementations. This series of tasks are just "things to consider" for the argparse patch.

Xqt added a parent task: T182523: option conflict (tracking).Jan 29 2021, 12:45 PM
Xqt removed a parent task: T76429: argparse support for global & pagegen arguments.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits