Page MenuHomePhabricator
Create Task
Maniphest T100539

MediaWiki:Uploadtext message shown together with AbuseFilter warning for action == "upload"
Closed, InvalidPublic
Actions

Description

If a user triggers a filter when uploading, and such filter is set to warn the user, then we show the MediaWiki:Uploadtext message above the filter's warning. However, this shouldn't happen because MediaWiki:Uploadtext is usually a friendly message, while filter warning messages may have a harsh tone, and in general the language and tone of these two messages is not likely to match with each other.

Related Objects

Mocks
Restricted Mockup

Event Timeline

Mahitgar created this task.May 27 2015, 6:23 PM
Mahitgar raised the priority of this task from to Needs Triage.
Mahitgar updated the task description. (Show Details)
Mahitgar added a project: AbuseFilter.
Mahitgar subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2015, 6:23 PM
Mahitgar renamed this task from Unexpected warning messages loading behaviours when we use parameter: action == "upload" to Unexpected warning messages loading behaviours, when we use parameter: action == "upload" .May 27 2015, 6:26 PM
Mahitgar set Security to None.
Mahitgar added a mock: Restricted Mockup.May 27 2015, 6:42 PM
Mahitgar renamed this task from Unexpected warning messages loading behaviours, when we use parameter: action == "upload" to Edit filter warning message's Unexpected loading behaviours, when we use parameter: action == "upload" .May 27 2015, 6:48 PM
Mahitgar added a subscriber: Nemo_bis.
Mahitgar added a subscriber: Billinghurst.
Mahitgar added a subscriber: He7d3r.May 28 2015, 6:05 AM
Luke081515 triaged this task as Medium priority.Dec 9 2015, 8:40 AM
Billinghurst unsubscribed.Dec 14 2015, 11:33 AM
Amire80 moved this task from Backlog to Uploading on the AbuseFilter board.May 8 2016, 8:43 AM
Daimona renamed this task from Edit filter warning message's Unexpected loading behaviours, when we use parameter: action == "upload" to MediaWiki:Uploadtext message shown together with AbuseFilter warning for action == "upload" .Oct 21 2018, 11:55 AM
Daimona updated the task description. (Show Details)
Daimona closed this task as Invalid.Oct 21 2018, 12:00 PM
Daimona subscribed.

I rewrote the task description to make it easier to understand. The second part was removed as we already have T187072. As for the remaining part, I'm closing it as invalid because now the interface is different: the uploadtext message is still there, but the filter warning is inside the section having the message "uploaderror" as title. Now the messages are clearly separated, and also it's completely fine to keep an introduction on Special:Upload.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL