Page MenuHomePhabricator

MediaWiki Codesniffer tests are failing on pre-HHVM 3.5.0 versions
Closed, ResolvedPublic

Description

First observed in https://gerrit.wikimedia.org/r/#/c/196880/ and confirmed in https://gerrit.wikimedia.org/r/#/c/214103/, the php-composer-test-hhvm is failing for mediawiki/tools/codesniffer with the following message:

Fatal error: Call to undefined method Phar::running() in /mnt/jenkins-workspace/workspace/php-composer-test-hhvm/vendor/squizlabs/php_codesniffer/CodeSniffer.php on line 2369

As seen in addshore's comment below this has been fixed in a newer version of HHVM!

Event Timeline

polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)

So I did a bit of digging, we are currently running HHVM 3.3.1 on jenkins slaves.

Per this issue with hhvm:
https://github.com/facebook/hhvm/issues/4323
and this pull req
https://github.com/facebook/hhvm/pull/4353
this commit fixes the issue
https://github.com/facebook/hhvm/commit/7d53dd076f8f5b71947b963068d3bdf11a43b176
Which means we need an update to one of the below hhvm versions

HHVM-3.7.1 HHVM-3.7.0 HHVM-3.6.3 HHVM-3.6.2 HHVM-3.6.1 HHVM-3.6.0 HHVM-3.5.1 HHVM-3.5.0

production is currently runnning on 3.6.1, any chance the jenkins slaves could also get the update?

Addshore renamed this task from Fix failing HHVM test for Codesniffer master to Upgrade Jenkins slave nodes to HHVM 3.5.0 or above.May 28 2015, 10:01 AM
Addshore updated the task description. (Show Details)

mediawiki/core tests broke when upgrading hhvm from 3.3.1+dfsg1-1+wm3.1 to 3.6.1+dfsg1-1+wm2 which is T98876.

Change 214901 had a related patch set uploaded (by Legoktm):
Don't try running tests on older versions of HHVM

https://gerrit.wikimedia.org/r/214901

Legoktm renamed this task from Upgrade Jenkins slave nodes to HHVM 3.5.0 or above to MediaWiki Codesniffer tests are failing on pre-HHVM 3.5.0 versions.May 31 2015, 9:03 AM

Change 214901 merged by jenkins-bot:
Don't try running tests on older versions of HHVM

https://gerrit.wikimedia.org/r/214901

Legoktm claimed this task.

This is fixed now, in MW-CS we're using 2.3.0 explicitly, and my upstream PR has also been merged, so when they do a new release we can update too.

Change 283967 had a related patch set (by Addshore) published:
Require-dev "squizlabs/php_codesniffer": "~2.3"

https://gerrit.wikimedia.org/r/283967

Change 283967 abandoned by Addshore:
Require-dev "squizlabs/php_codesniffer": "~2.3"

Reason:
So apparently this ~2.3 check is no longer needed!

https://gerrit.wikimedia.org/r/283967

Change 283966 abandoned by Addshore:
Relax squizlabs/php_codesniffer version requirement

Reason:
See https://phabricator.wikimedia.org/T133011 as decided way forward

https://gerrit.wikimedia.org/r/283966