Page MenuHomePhabricator
Create Task
Maniphest T100544

MediaWiki Codesniffer tests are failing on pre-HHVM 3.5.0 versions
Closed, ResolvedPublic
Actions

Description

First observed in https://gerrit.wikimedia.org/r/#/c/196880/ and confirmed in https://gerrit.wikimedia.org/r/#/c/214103/, the php-composer-test-hhvm is failing for mediawiki/tools/codesniffer with the following message:

Fatal error: Call to undefined method Phar::running() in /mnt/jenkins-workspace/workspace/php-composer-test-hhvm/vendor/squizlabs/php_codesniffer/CodeSniffer.php on line 2369

As seen in addshore's comment below this has been fixed in a newer version of HHVM!

Details

SubjectRepoBranchLines +/-
Relax squizlabs/php_codesniffer version requirementmediawiki/tools/codesniffermaster+2 -2
Require-dev "squizlabs/php_codesniffer": "~2.3"mediawiki/coremaster+1 -0
Don't try running tests on older versions of HHVMmediawiki/tools/codesniffermaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

polybuildr created this task.May 27 2015, 6:48 PM
polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
polybuildr added a project: MediaWiki-Codesniffer.
polybuildr added subscribers: polybuildr, Addshore, hashar, Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2015, 6:48 PM
Addshore added projects: HHVM, Jenkins.May 27 2015, 6:49 PM
Addshore set Security to None.
hashar removed a project: Jenkins.May 27 2015, 8:20 PM
Addshore added a comment.May 28 2015, 9:58 AM

So I did a bit of digging, we are currently running HHVM 3.3.1 on jenkins slaves.

Per this issue with hhvm:
https://github.com/facebook/hhvm/issues/4323
and this pull req
https://github.com/facebook/hhvm/pull/4353
this commit fixes the issue
https://github.com/facebook/hhvm/commit/7d53dd076f8f5b71947b963068d3bdf11a43b176
Which means we need an update to one of the below hhvm versions

HHVM-3.7.1 HHVM-3.7.0 HHVM-3.6.3 HHVM-3.6.2 HHVM-3.6.1 HHVM-3.6.0 HHVM-3.5.1 HHVM-3.5.0

production is currently runnning on 3.6.1, any chance the jenkins slaves could also get the update?

Addshore triaged this task as Medium priority.May 28 2015, 9:59 AM
Addshore renamed this task from Fix failing HHVM test for Codesniffer master to Upgrade Jenkins slave nodes to HHVM 3.5.0 or above.May 28 2015, 10:01 AM
Addshore updated the task description. (Show Details)
Addshore added a project: Continuous-Integration-Infrastructure.
hashar added a comment.May 28 2015, 10:06 AM

mediawiki/core tests broke when upgrading hhvm from 3.3.1+dfsg1-1+wm3.1 to 3.6.1+dfsg1-1+wm2 which is T98876.

hashar added a subtask: T98876: "mediawiki-phpunit-hhvm" failures on all changes in mediawiki/core due to hhvm upgrade from 3.3.1+dfsg1-1+wm3.1 to 3.6.1+dfsg1-1+wm2.May 28 2015, 10:06 AM
hashar moved this task from Untriaged to Externally Blocked on the Continuous-Integration-Infrastructure board.
gerritbot subscribed.May 31 2015, 9:03 AM

Change 214901 had a related patch set uploaded (by Legoktm):
Don't try running tests on older versions of HHVM

https://gerrit.wikimedia.org/r/214901

gerritbot added a project: Patch-For-Review.May 31 2015, 9:03 AM
Legoktm renamed this task from Upgrade Jenkins slave nodes to HHVM 3.5.0 or above to MediaWiki Codesniffer tests are failing on pre-HHVM 3.5.0 versions.May 31 2015, 9:03 AM
Legoktm added a comment.May 31 2015, 9:18 AM

Hmm, this was introduced upstream in https://github.com/squizlabs/PHP_CodeSniffer/commit/a90531b3cbcc771fb7cf777484ac50dcf0223f7b, so we could just pin to 2.3.0 instead of ~2.0...

gerritbot added a comment.May 31 2015, 9:26 AM

Change 214901 merged by jenkins-bot:
Don't try running tests on older versions of HHVM

https://gerrit.wikimedia.org/r/214901

Legoktm added a comment.May 31 2015, 9:29 AM

I also submitted an upstream fix at https://github.com/squizlabs/PHP_CodeSniffer/pull/607

Legoktm mentioned this in rMCSNddc3a648fa65: Don't try running tests on older versions of HHVM.May 31 2015, 12:40 PM
polybuildr mentioned this in T92754: mediawiki/tools/codesniffer should pass phpcs.Jun 1 2015, 9:36 AM
Legoktm closed this task as Resolved.Jun 7 2015, 6:18 AM
Legoktm claimed this task.

This is fixed now, in MW-CS we're using 2.3.0 explicitly, and my upstream PR has also been merged, so when they do a new release we can update too.

Legoktm removed a subtask: T98876: "mediawiki-phpunit-hhvm" failures on all changes in mediawiki/core due to hhvm upgrade from 3.3.1+dfsg1-1+wm3.1 to 3.6.1+dfsg1-1+wm2.Jun 7 2015, 6:18 AM
hashar moved this task from Externally Blocked to Done on the Continuous-Integration-Infrastructure board.Jun 23 2015, 9:08 AM
gerritbot added a comment.Apr 18 2016, 1:30 PM

Change 283967 had a related patch set (by Addshore) published:
Require-dev "squizlabs/php_codesniffer": "~2.3"

https://gerrit.wikimedia.org/r/283967

gerritbot added a comment.Apr 19 2016, 7:35 AM

Change 283967 abandoned by Addshore:
Require-dev "squizlabs/php_codesniffer": "~2.3"

Reason:
So apparently this ~2.3 check is no longer needed!

https://gerrit.wikimedia.org/r/283967

gerritbot added a comment.Apr 19 2016, 7:45 AM

Change 283966 abandoned by Addshore:
Relax squizlabs/php_codesniffer version requirement

Reason:
See https://phabricator.wikimedia.org/T133011 as decided way forward

https://gerrit.wikimedia.org/r/283966

Addshore mentioned this in T133011: Split codesniffer repo into 2 (codesniffer & codesniffer-sniffs).Apr 19 2016, 7:49 AM
hashar unsubscribed.Apr 19 2016, 8:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL