Page MenuHomePhabricator

URL endpoint broken on master
Closed, InvalidPublic

Description

curl -d '{"url":"http:/www.example.com", "format":"mediawiki"}' --header "Content-Type: application/json" localhost:1970/url

Causes:

{"name":"citoid","hostname":"marielle","pid":16910,"level":40,"err":{"message":"Invalid URI \"http:/www.example.com\"","name":"citoid","stack":"citoid: Invalid URI \"http:/www.example.com\"\n    at Request.init (/home/marielle/Code/Node/citoid/node_modules/request/request.js:443:31)\n    at new Request (/home/marielle/Code/Node/citoid/node_modules/request/request.js:283:8)\n    at request (/home/marielle/Code/Node/citoid/node_modules/request/index.js:50:10)\n    at Scraper.scrape (/home/marielle/Code/Node/citoid/lib/Scraper.js:48:2)\n    at CitoidService.scrape (/home/marielle/Code/Node/citoid/lib/CitoidService.js:375:3)\n    at /home/marielle/Code/Node/citoid/lib/CitoidService.js:102:12\n    at Request._callback (/home/marielle/Code/Node/citoid/lib/unshorten.js:18:5)\n    at self.callback (/home/marielle/Code/Node/citoid/node_modules/request/request.js:373:22)\n    at Request.EventEmitter.emit (events.js:95:17)\n    at Request.init (/home/marielle/Code/Node/citoid/node_modules/request/request.js:443:17)\n    at new Request (/home/marielle/Code/Node/citoid/node_modules/request/request.js:283:8)\n    at request (/home/marielle/Code/Node/citoid/node_modules/request/index.js:50:10)\n    at unshorten (/home/marielle/Code/Node/citoid/lib/unshorten.js:13:3)\n    at /home/marielle/Code/Node/citoid/lib/CitoidService.js:80:5\n    at Request._callback (/home/marielle/Code/Node/citoid/lib/ZoteroService.js:54:4)\n    at Request.self.callback (/home/marielle/Code/Node/citoid/node_modules/request/request.js:373:22)"},"msg":"Invalid URI \"http:/www.example.com\"","time":"2015-05-27T18:47:51.452Z","v":0}

Not surprising since we don't have any tests for url endpoint- we need to either get tests or remove endpoint soon as per: T93514

Event Timeline

Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added subscribers: Mvolz, mobrovac.

Nevermind, it really *was* an invalid URI. But point still stands about lack of tests vs. removing endpoint to stop me from filing erroneous bug reports like this in the future :).