Page MenuHomePhabricator
Create Task
Maniphest T100562

Validation and error display for mustache form
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The mustache form needs to display errors from the gateway adapter's server-side validation and needs to validate client-side on submit.
Definitely need to validate required fields, currency code and amount. Bonus points for checking that CPF has a reasonable number of digits. If amount or currency code are invalid, the user should be able to correct them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deal with errors that are arraysmediawiki/extensions/DonationInterfacedeployment+7 -1
Deal with errors that are arraysmediawiki/extensions/DonationInterfacemaster+7 -1
Initial validation for mustache formsmediawiki/extensions/DonationInterfacemaster+47 -5
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.May 27 2015, 8:59 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: Fundraising Sprint Lou Reed, [DO NOT USE] Astropay [superseded by #FR-Astropay].
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2015, 8:59 PM
Ejegg renamed this task from Validate data in mustache form to Validation and error display for mustache form.May 27 2015, 9:00 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Lou Reed board.
Ejegg set Security to None.
Ejegg edited a custom field.
Ejegg updated the task description. (Show Details)May 27 2015, 9:03 PM
gerritbot subscribed.May 28 2015, 2:06 AM

Change 214286 had a related patch set uploaded (by Ejegg):
WIP validate stuff

https://gerrit.wikimedia.org/r/214286

gerritbot added a project: Patch-For-Review.May 28 2015, 2:06 AM
• atgo moved this task from Backlog to Required for internal testing on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.May 29 2015, 2:30 PM
• atgo moved this task from Required for internal testing to Required for donor testing on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Jun 3 2015, 11:19 PM
gerritbot added a comment.Jun 4 2015, 9:48 PM

Change 214286 merged by jenkins-bot:
Initial validation for mustache forms

https://gerrit.wikimedia.org/r/214286

awight mentioned this in rEDOIf070713a6f02: Initial validation for mustache forms.Jun 4 2015, 9:48 PM
Ejegg mentioned this in rMEXT71f2052fbf59: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jun 4 2015, 9:48 PM
Ejegg moved this task from Doing to Done on the Fundraising Sprint Lou Reed board.Jun 4 2015, 10:41 PM
Ejegg closed this task as Resolved.Jun 4 2015, 10:43 PM
• atgo moved this task from Required for donor testing to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Jun 8 2015, 5:47 PM
gerritbot added a comment.Jun 8 2015, 7:40 PM

Change 216767 had a related patch set uploaded (by Ejegg):
Deal with errors that are arrays

https://gerrit.wikimedia.org/r/216767

gerritbot added a comment.Jun 8 2015, 10:18 PM

Change 216767 merged by jenkins-bot:
Deal with errors that are arrays

https://gerrit.wikimedia.org/r/216767

Ejegg mentioned this in rMEXTde4ab3093af7: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jun 8 2015, 10:18 PM
awight mentioned this in rEDOI6f8a7d3eca08: Deal with errors that are arrays.Jun 8 2015, 10:18 PM
gerritbot added a comment.Jun 11 2015, 5:30 PM

Change 217564 had a related patch set uploaded (by Ejegg):
Deal with errors that are arrays

https://gerrit.wikimedia.org/r/217564

gerritbot added a comment.Jun 11 2015, 5:31 PM

Change 217564 merged by Ejegg:
Deal with errors that are arrays

https://gerrit.wikimedia.org/r/217564

Ejegg mentioned this in rEDOI4e9b7e938112: Deal with errors that are arrays.Jun 11 2015, 5:32 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 14 2015, 7:15 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits