Page MenuHomePhabricator

make-release should run a syntax checker over the generated tarball
Open, MediumPublic

Description

To avoid the fiasco that T100351 caused, we should run a PHP / JSON / JavaScript syntax checker over the generated tarball before publishing it. We can likely re-use the PHP syntax checker developed in scap.

Event Timeline

Legoktm created this task.May 28 2015, 2:04 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added subscribers: Legoktm, demon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 2:04 AM
greg updated the task description. (Show Details)May 28 2015, 5:10 PM
greg added a project: Deployments.
greg set Security to None.
hashar added a subscriber: hashar.May 29 2015, 9:49 AM

That was the idea behind the https://integration.wikimedia.org/ci/job/mediawiki-core-release/ job. On tag we would run the release script then do a bunch of test against it (ex: does it install, pass qunit, lint files etc).

thcipriani triaged this task as Medium priority.Jun 1 2015, 6:21 PM
thcipriani moved this task from To Triage to Backlog (Tech) on the Deployments board.
demon added a comment.May 15 2018, 9:19 AM

Should be easy enough with the pytest script I have checking the tarball. Just another test case to add :)

hashar removed a subscriber: hashar.Mar 27 2019, 8:09 AM