Page MenuHomePhabricator

-limit argument conflict
Open, LowPublic

Description

-limit is handled in pagegens, but is also implemented in casechecker.py , checkimages.py, reflinks.py and welcome.py

interwiki.py has a -limittwo option, which is unrelated.

Also, lonelypages.py has its own documentation for -limit instead of using the pagegen documentation.

Event Timeline

jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb added subscribers: jayvdb, Unknown Object (MLST).
jayvdb set Security to None.

There is a bug in checkimages -limit arg handling (inherited from compat)

$ python pwb.py checkimages -limit
Traceback (most recent call last):
  File "pwb.py", line 248, in <module>
    if not main():
  File "pwb.py", line 242, in main
    run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 120, in run_python_file
    main_mod.__dict__)
  File "./scripts/checkimages.py", line 1775, in <module>
    main()
  File "./scripts/checkimages.py", line 1604, in main
    limit = int(arg[7:])
ValueError: invalid literal for int() with base 10: ''
<type 'exceptions.ValueError'>
CRITICAL: Closing network session.

Change 281131 had a related patch set uploaded (by Xqt):
[bugfix] bugfixes and improvements for checkimages

https://gerrit.wikimedia.org/r/281131

Change 281673 had a related patch set uploaded (by Xqt):
[bugfix] bugfixes and improvements for checkimages

https://gerrit.wikimedia.org/r/281673

Xqt triaged this task as Low priority.Apr 6 2016, 1:24 PM