Page MenuHomePhabricator
Create Task
Maniphest T100635

$wgDebugToolbar = true breaks ApiOpenSearch, and by proxy the suggestions bar on most pages
Closed, ResolvedPublic
Actions

Description

The suggestions API returns a plain javascript list, rather than an object like most things. The results are accessed as result[2] and such. Enabling the $wgDebugToolbar adds the debug data as the first entry in the list, shifting all the ApiOpenSearch results away from the expected index.

Details

SubjectRepoBranchLines +/-
ApiOpenSearch: Ignore any other unexpected keys in json outputmediawiki/coreREL1_25+15 -1
ApiOpenSearch: Ignore any other unexpected keys in json outputmediawiki/coremaster+13 -1
Customize query in gerrit

Related Objects

Event Timeline

EBernhardson created this task.May 28 2015, 9:52 AM
EBernhardson raised the priority of this task from to Needs Triage.
EBernhardson updated the task description. (Show Details)
EBernhardson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 9:52 AM
EBernhardson added a project: Discovery-ARCHIVED.May 28 2015, 9:53 AM
EBernhardson set Security to None.
Ciencia_Al_Poder edited projects, added MediaWiki-Debug-Logger, MediaWiki-Action-API; removed Discovery-ARCHIVED.May 28 2015, 9:59 AM
Ciencia_Al_Poder subscribed.May 28 2015, 10:14 AM

Example:

P697 T100635 example
1With $wgDebugToolbar = false;
2
3["Te",["Test page link 1","Test page link 10","Test page link 11","Test page link 12","Test page link 13","Test page link 14","Test page link 15","Test page link 16","Test page link 17","Test page link 18"],["","","","","","","","","",""],["http://mediawiki-git.localwiki.com/wiki/Test_page_link_1","http://mediawiki-git.localwiki.com/wiki/Test_page_link_10","http://mediawiki-git.localwiki.com/wiki/Test_page_link_11","http://mediawiki-git.localwiki.com/wiki/Test_page_link_12","http://mediawiki-git.localwiki.com/wiki/Test_page_link_13","http://mediawiki-git.localwiki.com/wiki/Test_page_link_14","http://mediawiki-git.localwiki.com/wiki/Test_page_link_15","http://mediawiki-git.localwiki.com/wiki/Test_page_link_16","http://mediawiki-git.localwiki.com/wiki/Test_page_link_17","http://mediawiki-git.localwiki.com/wiki/Test_page_link_18"]]
4
5With $wgDebugToolbar = true; (pretty-printed)
6
7[
8 {
9 "mwVersion": "1.26alpha",
10 "phpEngine": "PHP",
11 "phpVersion": "5.6.1",
12 "gitRevision": "aab8487351dcf4f063e5db6a51bf5a7dc360ad60",
13 "gitBranch": "T78053",
14 "time": 0.090883016586304,
15 "log": [
16 {
17 "msg": "MWDebug output complete",
18 "type": "log",
19 "caller": "MWDebug::appendDebugInfoToApiResult"
20 }
21 ],
22 "debugLog": [
23 ],
24 "queries": [
25 ],
26 "request": {
27 "method": "GET",
28 "url": "\/api.php?action=opensearch&search=Te",
29 "headers": {
30 "HOST": "mediawiki-git.localwiki.com",
31 "USER-AGENT": "Mozilla\/5.0 (X11; Linux x86_64; rv:38.0) Gecko\/20100101 Firefox\/38.0",
32 "ACCEPT": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,*\/*;q=0.8",
33 "ACCEPT-LANGUAGE": "es-ES,es;q=0.8,en-US;q=0.6,en;q=0.4,ca;q=0.2",
34 "ACCEPT-ENCODING": "gzip, deflate",
35 "REFERER": "http:\/\/mediawiki-git.localwiki.com\/api.php?action=help&modules=opensearch",
36 "COOKIE": "mwgitUserName=Jesus; mwgitUserID=1",
37 "CONNECTION": "keep-alive",
38 "CACHE-CONTROL": "max-age=0"
39 },
40 "params": {
41 "action": "opensearch",
42 "search": "Te"
43 }
44 },
45 "memory": "10,95 MB",
46 "memoryPeak": "11,41 MB",
47 "includes": [
48 ]
49 },
50 "Te",
51 [
52 "Test page link 1",
53 "Test page link 10",
54 "Test page link 11",
55 "Test page link 12",
56 "Test page link 13",
57 "Test page link 14",
58 "Test page link 15",
59 "Test page link 16",
60 "Test page link 17",
61 "Test page link 18"
62 ],
63 [
64 "",
65 "",
66 "",
67 "",
68 "",
69 "",
70 "",
71 "",
72 "",
73 ""
74 ],
75 [
76 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_1",
77 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_10",
78 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_11",
79 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_12",
80 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_13",
81 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_14",
82 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_15",
83 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_16",
84 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_17",
85 "http:\/\/mediawiki-git.localwiki.com\/wiki\/Test_page_link_18"
86 ]
87]
88

gerritbot subscribed.May 28 2015, 2:41 PM

Change 214347 had a related patch set uploaded (by Anomie):
ApiOpenSearch: Ignore any other unexpected keys in json output

https://gerrit.wikimedia.org/r/214347

gerritbot added a project: Patch-For-Review.May 28 2015, 2:41 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.May 28 2015, 2:42 PM
Anomie added a project: Reading-Infrastructure-Team-Old (Don't use).
Anomie moved this task from Backlog to Needs Review/Feedback on the Reading-Infrastructure-Team-Old (Don't use) board.
Umherirrender closed this task as Resolved.May 29 2015, 8:29 PM
Umherirrender claimed this task.
Anomie claimed this task.May 29 2015, 8:36 PM
gerritbot added a comment.May 29 2015, 8:37 PM

Change 214347 merged by jenkins-bot:
ApiOpenSearch: Ignore any other unexpected keys in json output

https://gerrit.wikimedia.org/r/214347

Umherirrender mentioned this in rMW0e6b9fdb6fd2: ApiOpenSearch: Ignore any other unexpected keys in json output.May 29 2015, 8:37 PM
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-06-09_(1.26wmf9).May 29 2015, 9:00 PM
• Forrestbot subscribed.
gerritbot added a comment.Jun 5 2015, 8:50 PM

Change 216311 had a related patch set uploaded (by Anomie):
ApiOpenSearch: Ignore any other unexpected keys in json output

https://gerrit.wikimedia.org/r/216311

Anomie merged a task: T101555: Enabling the debug toolbar interferes with search completions.Jun 5 2015, 8:51 PM
Anomie added a subscriber: MarkAHershberger.
gerritbot added a comment.Jun 5 2015, 9:02 PM

Change 216311 merged by jenkins-bot:
ApiOpenSearch: Ignore any other unexpected keys in json output

https://gerrit.wikimedia.org/r/216311

Anomie mentioned this in rMW9f5519bccc41: ApiOpenSearch: Ignore any other unexpected keys in json output.Jun 5 2015, 9:03 PM
• Forrestbot added a project: MW-1.25-release.Jun 8 2015, 5:30 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
bd808 moved this task from Needs Review/Feedback to Done on the Reading-Infrastructure-Team-Old (Don't use) board.Jul 6 2015, 4:00 PM
Legoktm merged a task: T104905: wgDebugToolbar breaking search box in 1.25.Jul 6 2015, 8:05 PM
Legoktm added subscribers: Krenair, Rosencrantz.
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Reading-Infrastructure-Team-Old (Don't use).Jun 7 2017, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL