When patches are proposed to mediawiki/core branch fundraising/REL1_25, zuul-cloner fallback to master instead of REL1_25. The mediawiki-testextensions-* jobs use zuul-cloner with a bunch of extensions and should use --branch REL1_25. Since the release branch has the extensions as submodules, we should really use git submodule update instead.
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Ejegg | T89404 Create unit and integration tests for Fundraising extensions to identify breaking MediaWiki changes | |||
Declined | None | T100637 mediawiki/core fundraising/REL branches should use git submodule |
Event Timeline
Example console:
Fetched ref refs/zuul/fundraising/REL1_25/Z5f52a67f72bf4dbda3756677250fb515 from mediawiki/core Project mediawiki/vendor in Zuul does not have ref refs/zuul/fundraising/REL1_25/Z5f52a67f72bf4dbda3756677250fb515 Falling back to branch master Prepared mediawiki/vendor repo with branch master
Should be REL1_25.
mediawiki/core fundraising branches are similar to the wmf branch. So we have no need to use the mediawiki-extensions-* job but should instead use the submodules.
I forgot the fundraising branches are similar to the wmf branches. We should use git submodule update instead of cloning a bunch of extensions.
@hashar: Thanks for noticing this, and for the workaround! In the long run we definitely want the extensions tests to run, I'll see if I can make this change in the CI config.
Ah, another annoying issue is that we currently can't reference anything from DonationInterface/vendor in tests, because the production branch has tests removed and vendor/ as a submodule, and the development branch has no vendor/. CI populates mediawiki-core/vendor with stock wmf deployment libraries, without incorporating extra libraries mentioned in DonationInterface/composer.json.
Seems for dev we will want to run composer to fetch the DonationInterface dependencies.
For production branch, I guess that would need a different job that process submodules.
I am not sure about the testing strategy to be honest :-(
That is from several years, I have long lost track of what this task was about or whether it should actually be done.