Page MenuHomePhabricator

mediawiki/core fundraising/REL branches should use git submodule
Closed, DeclinedPublic

Description

When patches are proposed to mediawiki/core branch fundraising/REL1_25, zuul-cloner fallback to master instead of REL1_25. The mediawiki-testextensions-* jobs use zuul-cloner with a bunch of extensions and should use --branch REL1_25. Since the release branch has the extensions as submodules, we should really use git submodule update instead.

Event Timeline

hashar assigned this task to awight.
hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added subscribers: atgo, Jgreen, gerritbot and 4 others.

Example console:

Fetched ref refs/zuul/fundraising/REL1_25/Z5f52a67f72bf4dbda3756677250fb515 from mediawiki/core
Project mediawiki/vendor in Zuul does not have ref refs/zuul/fundraising/REL1_25/Z5f52a67f72bf4dbda3756677250fb515
Falling back to branch master
Prepared mediawiki/vendor repo with branch master

Should be REL1_25.

hashar triaged this task as Unbreak Now! priority.
hashar moved this task from Backlog to In progress on the Continuous-Integration-Config board.

Blocks fundraising tech

mediawiki/core fundraising branches are similar to the wmf branch. So we have no need to use the mediawiki-extensions-* job but should instead use the submodules.

I forgot the fundraising branches are similar to the wmf branches. We should use git submodule update instead of cloning a bunch of extensions.

hashar renamed this task from fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs to mediawiki/core fundraising/REL branches should use git submodule.May 28 2015, 11:39 AM
hashar lowered the priority of this task from Unbreak Now! to Medium.
hashar updated the task description. (Show Details)
hashar set Security to None.

@hashar: Thanks for noticing this, and for the workaround! In the long run we definitely want the extensions tests to run, I'll see if I can make this change in the CI config.

Ah, another annoying issue is that we currently can't reference anything from DonationInterface/vendor in tests, because the production branch has tests removed and vendor/ as a submodule, and the development branch has no vendor/. CI populates mediawiki-core/vendor with stock wmf deployment libraries, without incorporating extra libraries mentioned in DonationInterface/composer.json.

Seems for dev we will want to run composer to fetch the DonationInterface dependencies.

For production branch, I guess that would need a different job that process submodules.

I am not sure about the testing strategy to be honest :-(

hashar moved this task from In progress to Backlog on the Continuous-Integration-Config board.

That is from several years, I have long lost track of what this task was about or whether it should actually be done.