Page MenuHomePhabricator

False positive at first edit itself, where as actually edit filter has a rate limit to triger latter after given number of instances.
Closed, DuplicatePublic

Description

On mr-wikipedia among edit filters having any "Trigger actions only if the user trips a rate limit" condition we observed, in few - once in a while - instances, users came for editing after many days gap. But still filter got activated/tripped on their first attempt of edit for that day. Say if Number of actions to allow(Anzahl erlaubter Aktionen:): is 3 then filter should get active on fourth action. But in some cases filter got active on first edit of the editor for the day.

For example https://mr.wikipedia.org/wiki/विशेष:संपादनगाळणी_नोंदी/56004 this edit filter log, prima facia it is a first edit of the ip user 180.234.111.52 on mr wikipedia. The given edit filter no. 127 was supposed to trip after 4 actions, where as filter actually tripped on the first action it self.

Usually we have observed this problem on edit filter with condition Group throttle by(Regeln für die Gruppendrossel): page;

On their first edit for the day,an user/editor is not doing any other action , at the most user can see preview multiple times.(And no other user has edited that page for long time.)

So my doubt is whether Number of actions to allow(Anzahl erlaubter Aktionen:): is counting user's preview action before saving the edit and giving falls positives to the filter ?

While previously I have tried to reproduce this bug, but have not been successfull uptil now.

(I used few German words here since earlier previously I communicated with few de wikipedians to find if they have observed any such instance. It seems usually edit filter patrollers do not seem to check if an edit is first ever edit for any given user or not, So problem may have not been observed by others or I am missing something somewhere in my edit filters, `Group throttle by(Regeln für die Gruppendrossel): page filters on mr wikipedia are usually based on filter no 37 of de wikipedia.

Regards

Event Timeline

Mahitgar raised the priority of this task from to Needs Triage.
Mahitgar updated the task description. (Show Details)
Mahitgar added a project: AbuseFilter.
Mahitgar added a subscriber: Mahitgar.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 10:17 AM
Mahitgar renamed this task from Falls positive at first edit itself, where as actually edit filter has a rate limit to triger latter after given number of instances. to False positive at first edit itself, where as actually edit filter has a rate limit to triger latter after given number of instances..Jun 2 2015, 4:14 PM
Mahitgar set Security to None.

I came across T86434 bug from nl-wikipedia where in a filter got triggered before given rate limit