Page MenuHomePhabricator
Create Task
Maniphest T100646

VE and ISBN numbers: Adds empty nowiki tag and introduces unnecessary link to Special:BookSources
Closed, DuplicatePublic
Actions

Description

I only tried to change the numbers in ISBN

https://en.wikipedia.org/w/index.php?title=Ferhat_Atik&diff=664403087&oldid=664402977

Note that in Wikipedia

ISBN 978-605-5395-11-1

it is sufficient in order to link to Special:BookSources

Related Objects

Event Timeline

Magioladitis created this task.May 28 2015, 11:38 AM
Magioladitis raised the priority of this task from to Needs Triage.
Magioladitis updated the task description. (Show Details)
Magioladitis added a project: VisualEditor.
Magioladitis subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 11:38 AM
Magioladitis renamed this task from VE ans ISBN numbers: Add empty nowiki tag and introduces unnecessary link to Special to VE and ISBN numbers: Adds empty nowiki tag and introduces unnecessary link to Special:BookSources.May 28 2015, 11:38 AM
Magioladitis set Security to None.
mgrabovsky subscribed.May 28 2015, 12:40 PM
matmarex subscribed.May 28 2015, 2:07 PM

I think this happened because you accidentally unlinked the last number of the ISBN, which made the link necessary. In this case this is a dupe of T74108: [Regression wmf4] Link continuation is broken, which makes this kind of thing easy to do and hard to notice.

matmarex closed this task as a duplicate of T74108: [Regression wmf4] Link continuation is broken.May 28 2015, 2:07 PM
mgrabovsky added a comment.EditedMay 28 2015, 4:11 PM

Is this really the same bug? Cf. this edit, where I changed digits inside the identifier and the link was generated anyway. Is it because the magic link is handled as an ordinary link or because magic links are not handled correctly by VE/Parsoid?

It's also interesting that the Parsoid service at eqiad correctly removes the superfluous link after reverting to the original ISBN, while VE leaves the link around, cf. this later edit.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits