Page MenuHomePhabricator

License message is visible in footer when no license (wgRights*) is set
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Remove all global $wgRights* configuration variables
  • open a page in mobile view

Expected:
The license message in the footer shouldn't be visible.

Observed:
The license message in the footer is visible.

Event Timeline

Florian created this task.May 28 2015, 3:06 PM
Florian claimed this task.
Florian raised the priority of this task from to High.
Florian updated the task description. (Show Details)
Florian added a project: Readers-Web-Backlog.
Florian added a subscriber: Florian.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 3:06 PM

Change 214357 had a related patch set uploaded (by Florianschmidtwelzow):
Correctly determine if a license message should be printed or not

https://gerrit.wikimedia.org/r/214357

With them set to '' I see "Content is available under unless otherwise noted."
Surely this is the correct behaviour?
This patch removes that message altogether. What is the correct behaviour? (please reply on bug)

Hmm, it shouldn't be vsisible when:

  • the default value is set (null), which isn't the case actually
  • it is set to an empty string, which isn't the case actually
  • it's set to false (or any other value which is interpreted as boolean false in php), which isn't the case actually

I tested the change above with:

  • $wgRightsText = ''; -> no license message
  • $wgRightsText = null; -> no license message
  • $wgRightsText = flase; -> no license message
  • $wgRightstext = 'Test'; -> license messaeg visible

Can you very that this isn't a local cache issue? :)

@Florian I can confirm yes to all your examples - must have been a cache issue.

Change 214357 merged by jenkins-bot:
Correctly determine if a license message should be printed or not

https://gerrit.wikimedia.org/r/214357

phuedx closed this task as Resolved.Jun 2 2015, 3:28 PM
phuedx removed a project: Patch-For-Review.
phuedx set Security to None.
phuedx added a subscriber: phuedx.