| • Mholloway | |
| May 28 2015, 4:59 PM |
| F170803: Screenshot_2015-05-28-15-29-13.png | |
| May 28 2015, 7:38 PM |
| F170802: Screenshot_2015-05-28-15-29-06.png | |
| May 28 2015, 7:38 PM |
| F170733: Screenshot_2015-05-28-12-47-33.png | |
| May 28 2015, 5:02 PM |
| F170734: Screenshot_2015-05-28-12-47-42.png | |
| May 28 2015, 5:02 PM |
While trying out WP Beta on my Nexus 9 (5.1.1), I noticed that link preview version 2 is broken. It doesn't come up all the way, and text is cut off in portrait (no text at all in landscape). This is the case currently in the master dev branch as well.
It's fine on my phone (in both portrait and landscape).
Version 1 is fine on both devices, in both orientations. Only Version 2 is affected.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix margins on link preview dialog 2 (display correctly on tablets) | apps/android/wikipedia | master | +9 -4 |
Change 214417 had a related patch set uploaded (by Mholloway):
Fix margins on link preview dialog 2 (display correctly on tablets)
Caused by a bad margin setting in dialog_link_preview_2.xml. This has probably never displayed correctly on tablets. Fixed now. Still works on phones.
Change 214417 merged by jenkins-bot:
Fix margins on link preview dialog 2 (display correctly on tablets)
