Maniphest T100686

Refactor bannerController API as required for banner history
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

This is task 4 on the Banner History technical roadmap.

Details

	Subject	Repo	Branch	Lines +/-
	Refactor client-side API and RL modules for banner display	mediawiki/extensions/CentralNotice	campaign_mixins	+2 K -1 K
	Refactor BannerChoiceData => ChoiceData	mediawiki/extensions/CentralNotice	campaign_mixins	+111 -109

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		awight	T45250 Redo /beacon/impression system (formerly Special:RecordImpression) to remove extra round trips on all FR impressions (title was: S:RI should pyroperish)
		Declined		None	T90917 Get banner count via Special:BannerLoader
		Duplicate		None	T105109 Create UI for limiting banner impressions (banner diet?)
		Resolved		• atgo	T78089 [epic] Banner History MVP
		Resolved		• AndyRussG	T100686 Refactor bannerController API as required for banner history

Event Timeline

• AndyRussG created this task.May 28 2015, 6:27 PM

• AndyRussG claimed this task.

• AndyRussG raised the priority of this task from to Needs Triage.

• AndyRussG updated the task description. (Show Details)

• AndyRussG added a project: MediaWiki-extensions-CentralNotice.

• AndyRussG subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2015, 6:27 PM

• AndyRussG updated the task description. (Show Details)May 28 2015, 6:29 PM

• AndyRussG added a project: Fundraising Sprint Lou Reed.

• AndyRussG set Security to None.

• AndyRussG added a parent task: T78089: [epic] Banner History MVP.

• AndyRussG added a subscriber: • atgo.

• AndyRussG edited a custom field.May 29 2015, 3:36 PM

• AndyRussG added a project: Fundraising Sprint Miles Davis.Jun 10 2015, 10:55 PM

• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Miles Davis board.Jun 17 2015, 9:34 PM

Made some headway:

https://www.mediawiki.org/w/index.php?title=Extension:CentralNotice/Notes/Banner_controller_refactoring

• atgo triaged this task as High priority.Jun 17 2015, 10:18 PM

• AndyRussG added a project: Fundraising-Backlog.Jun 24 2015, 10:57 PM

• AndyRussG moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Jun 24 2015, 10:59 PM

• atgo added a project: Fundraising Sprint N*E*R*D.Jun 24 2015, 11:00 PM

• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint N*E*R*D board.Jun 24 2015, 11:05 PM

Change 221141 had a related patch set uploaded (by AndyRussG):
Refactor BannerChoiceData => ChoiceData

https://gerrit.wikimedia.org/r/221141

gerritbot added a project: Patch-For-Review.Jun 26 2015, 4:20 PM

Change 221141 merged by jenkins-bot:
Refactor BannerChoiceData => ChoiceData

https://gerrit.wikimedia.org/r/221141

• AndyRussG mentioned this in rECNO9456095b0586: Refactor BannerChoiceData => ChoiceData.Jun 26 2015, 4:51 PM

Change 221759 had a related patch set uploaded (by AndyRussG):
WIP - Pls. Don't Merge - Refactor banner display, RL modules and API for banners

https://gerrit.wikimedia.org/r/221759

• AndyRussG moved this task from Doing to Review on the Fundraising Sprint N*E*R*D board.Jul 8 2015, 6:55 AM

• DStrine added a project: Fundraising Sprint ODB.Jul 8 2015, 11:14 PM

• AndyRussG moved this task from Backlog to Review on the Fundraising Sprint ODB board.Jul 8 2015, 11:17 PM

• AndyRussG mentioned this in T106577: Spike: Determine how to load CentralNotice RL modules and when to execute campaign and banner selection logic.Jul 22 2015, 7:01 PM

• DStrine added a project: Fundraising Sprint The Pogues.Jul 22 2015, 8:02 PM

• AndyRussG moved this task from Backlog to Review on the Fundraising Sprint The Pogues board.Jul 22 2015, 8:03 PM

Change 221759 merged by jenkins-bot:
Refactor client-side API and RL modules for banner display

https://gerrit.wikimedia.org/r/221759

• AndyRussG mentioned this in rECNO9af91ae72adc: Refactor client-side API and RL modules for banner display.Aug 4 2015, 7:34 AM

• AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint The Pogues board.Aug 4 2015, 3:10 PM

• atgo added a project: Fundraising Sprint Queen.Aug 5 2015, 10:27 PM

• AndyRussG moved this task from Backlog to Pending Deployment on the Fundraising Sprint Queen board.Aug 5 2015, 10:29 PM

• atgo added a project: Fundraising Sprint Rowlf the Dog.Aug 19 2015, 10:58 PM

• AndyRussG moved this task from Backlog to Pending Deployment on the Fundraising Sprint Rowlf the Dog board.Aug 19 2015, 11:01 PM

• AndyRussG closed this task as Resolved.Sep 3 2015, 4:28 PM

• AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Rowlf the Dog board.

• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:40 PM